Percona Server moved to https://jira.percona.com/projects/PS

Atomic access issues with vars in response_time_distribution.patch

Bug #878022 reported by Laurynas Biveinis on 2011-10-19

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Percona Server moved to https://jira.percona.com/projects/PS	Fix Released	High	Laurynas Biveinis	Percona Server moved to https://jira.percona.com/projects/PS 5.5.18-23.0
	5.1	Fix Released	High	Laurynas Biveinis	Percona Server moved to https://jira.percona.com/projects/PS 5.1.60-13.1

Bug Description

Even with the bug 803865 fixed, couple of issues with atomic access in the response_time_distribution.patch remain:
1) The i386 CAS inline asm is missing "memory" and "volatile", see comments #10 and #11 at bug 803865. It is very likely that this bug is benign for now, still must be fixed.
2) The time_collector::m_count and m_total variables are declared volatile, which is wrong. Volatility has nothing to do with atomicity, volatile variables are those with unpredictable accesses. Here the accesses are very predictable.