can't import files more than one time

The problem seems to be linked with the "recently used" choice in the popup where I choose the files.

Hi,
I 've updated to Oneiric and I 'am not able to reproduce it. Check if you have installed the package gtk2-engines-pixbuf. The others dependencies are the same that the 1.3.0.
Have you installed Ubuntu 11.10 after an upgrade or does it is a fresh install ?

It's an upgrade, not a fresh install.

sudo apt-cache show openshot
Package: openshot
Priority: optional
Section: universe/video
Installed-Size: 47944
Maintainer: Ubuntu Developers <email address hidden>
Original-Maintainer: Jonathan Thomas <email address hidden>
Architecture: all
Version: 1.4.0-1
Depends: gtk2-engines-pixbuf, fontconfig, librsvg2-common, melt, python-gtk2, python-httplib2, python-imaging, python-mlt3 | python-mlt2, python-pygoocanvas, python-xdg, python (>= 2.5), python-support (>= 0.90.0)
Recommends: openshot-doc, frei0r-plugins
Suggests: blender (>= 2.5), inkscape
Filename: pool/universe/o/openshot/openshot_1.4.0-1_all.deb
Size: 16453926
MD5sum: 06f686e76bb5c6dfedfb6f939fcee4df
SHA1: 5d8561fd4803e4b136f1629c5de0c2b462278618
SHA256: 4dd82e2440cc80d466a295cd655c209738ce0519b029774de355fa4452e8c324
Description-fr: création et modification de vidéos et de films
 L'éditeur vidéo OpenShot est un éditeur non linéaire libre. Il peut créer
 et modifier des vidéos et des films en utilisant les formats vidéo, audio
 et d'image les plus répandus. Il permet de créer des vidéos pour YouTube,
 Flickr, Vimeo, Metacafe, iPod, Xbox et bien d'autres formats courants.
 .
 Features include:
  * Multiple tracks (layers)
  * Compositing, image overlays, and watermarks
  * Support for image sequences (rotoscoping)
  * Key-frame animation
  * Video and audio effects (chroma-key)
  * Transitions (lumas and masks)
  * 3D animation (titles and simulations)
  * Upload videos (YouTube and Vimeo supported)
Homepage: http://www.openshotvideo.com/
Description-md5: 72c010cc66925e047a20682e94c21979
Bugs: https://bugs.launchpad.net/ubuntu/+filebug
Origin: Ubuntu
Task: ubuntustudio-video

jylenhof@ubuntu-newportable:~$

jylenhof@ubuntu-newportable:~$ sudo apt-cache show gtk2-engines-pixbuf
Package: gtk2-engines-pixbuf
Priority: optional
Section: universe/graphics
Installed-Size: 1044
Maintainer: Ubuntu Desktop Team <email address hidden>
Original-Maintainer: Sebastien Bacher <email address hidden>
Architecture: i386
Source: gtk+2.0
Version: 2.24.6-0ubuntu5
Depends: libc6 (>= 2.3.6-6~), libcairo2 (>= 1.6.4-6.1), libgdk-pixbuf2.0-0 (>= 2.22.0), libglib2.0-0 (>= 2.27.3), libgtk2.0-0 (= 2.24.6-0ubuntu5), libgtk2.0-common
Filename: pool/universe/g/gtk+2.0/gtk2-engines-pixbuf_2.24.6-0ubuntu5_i386.deb
Size: 126804
MD5sum: 38136f8a91de0e6c0290b083bd6548b8
SHA1: 40c3ec3ccd0fb3372d42a50631eb779e96cfb292
SHA256: dc4814ca71d7d953157eebb428036a25610d99f220fe38f62230f8f43abf5456
Description-en: Pixbuf-based theme for GTK+ 2.x
 The GTK+ is a multi-platform toolkit for creating graphical user
 interfaces. Offering a complete set of widgets, the GTK+ is suitable
 for projects ranging from small one-off tools to complete application
 suites.
 .
 This package contains the pixbuf theme engine.
Multi-Arch: same
Homepage: http://www.gtk.org/
Description-md5: 50d418fbeaf537e41f3597ef4991533a
Bugs: https://bugs.launchpad.net/ubuntu/+filebug
Origin: Ubuntu
Supported: 18m
Task: xubuntu-desktop, mythbuntu-backend-master, mythbuntu-backend-slave, mythbuntu-desktop, mythbuntu-frontend, lubuntu-desktop, ubuntustudio-generation, ubuntustudio-recording, ubuntus...

I have again tried like I am in the same situation like you (cad upgrade to Natty at Oneiric) and I am not able to reproduce it.
Si tu veux me donner plus d'explications en français, je n 'y vois aucun inconvenient. :-)

So, in french :

- Démarrage d'Openshot
- Fichier Importer des fichiers
- Cliquer sur récémment utilisés dans la boite de dialogue
- Sélectionner des fichiers
- Cliquer sur ajouter
- Fichier Importer des fichiers
---> Aucune boite de dialogue n'apparait... et on a la trace donnée précédemment

Je confirme/ I confirm this issue.

state saved
project modified: Opened project
state saved
NEW SDL CONSUMER
on_frmMain_key_press_event
on_frmMain_key_press_event
on_frmMain_key_press_event
on_frmMain_key_press_event
on_mnuImportFiles_activate called with self.GtkImageMenuItem
project modified: Fichier ajouté
state saved
on_frmMain_key_press_event
on_frmMain_key_press_event
on_mnuImportFiles_activate called with self.GtkImageMenuItem
Autosaving...
project saved! - Mentalist
project modified: Fichier ajouté
state saved
on_frmMain_key_press_event
on_frmMain_key_press_event
on_mnuImportFiles_activate called with self.GtkImageMenuItem
Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.7/openshot/windows/MainGTK.py", line 1606, in on_mnuImportFiles_activate
    self.import_files_dialog = AddFiles.frmAddFiles(form=self, project=self.project)
  File "/usr/lib/pymodules/python2.7/openshot/windows/AddFiles.py", line 47, in __init__
    self.frmAddFiles.set_current_folder(preferences.Settings.app_state["import_folder"])
TypeError: Gtk.FileChooser.set_current_folder() argument 1 must be string, not None
on_frmMain_key_press_event
on_frmMain_key_press_event
project modified: Fichier supprimé
state saved
project modified: Fichier supprimé
state saved
on_mnuQuit1_activate called with self.GtkImageMenuItem
on_frmMain_destroy
olivier@LaptopNavi:~$

A première vue, cela vient de notre façon d'importer un fichier (ou des fichiers). Il semblerait qu'il ne reconnait pas le titre du fichier importé.
Pour ma part, je dois dire que c'est la 1ere fois que j'importe un fichier de cette matière. Merci de m'avoir apris quelque chose.

At first look, it seems to come from our mean to import a file (or files). He does'nt look the title of the imported file.
For me, I must said that the first time that I import a file with this mean. Thx a lot for learning me something.

I think this must related to this bug:

https://bugs.launchpad.net/openshot/+bug/838940

There seems to be a general problem with the Recent Files manager in Unity/Ubuntu...

Hum Unity seems to come with some little bugs/issues. Good point Andy. :-)

2011/10/26 Andy Finch <email address hidden>

> I think this must related to this bug:
>
> https://bugs.launchpad.net/openshot/+bug/838940
>
> There seems to be a general problem with the Recent Files manager in
> Unity/Ubuntu...
>
> --
> You received this bug notification because you are a member of OpenShot
> Developers, which is subscribed to openshot in Ubuntu.
> https://bugs.launchpad.net/bugs/874906
>
> Title:
> can't import files more than one time
>
> Status in “openshot” package in Ubuntu:
> Confirmed
>
> Bug description:
> Ubuntu 11.10
>
> Launch openshot
> In the "Project Files" tab
> Do "Import Files", select one or more files, click "Add"
> Then do it again.... the popup does'nt appear
>
> in a terminal I have this trace :
> project modified: Added file
> state saved
> Traceback (most recent call last):
> File "/usr/lib/pymodules/python2.7/openshot/windows/MainGTK.py", line
> 4459, in on_mnuAddFile_activate
> self.import_files_dialog = AddFiles.frmAddFiles(form=self.form,
> project=self.project)
> File "/usr/lib/pymodules/python2.7/openshot/windows/AddFiles.py", line
> 47, in __init__
>
> self.frmAddFiles.set_current_folder(preferences.Settings.app_state["import_folder"])
> TypeError: Gtk.FileChooser.set_current_folder() argument 1 must be
> string, not None
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu/+source/openshot/+bug/874906/+subscriptions
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openshot.developers
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openshot.developers
> More help : https://help.launchpad.net/ListHelp
>

--
Olivier
Cenwen un elfe sur la banquise/ an elve on the ice
Mon blog perso sur le multimédia, Ubuntu, Linux et OpenShot :
http://linuxevolution.wordpress.com/
Le forum d'Openshot où vous me trouverez : http://openshotusers.com/
http://openshotusers.com/forum/index.php
Nothing is lost until the last second.
The family motto : When we want, we can.

I'm not using Unity, I use gnome-shell
So more gnome3 topic I think

Regards,

I have a temporary fix for 1.4.0, which can be attained by commenting out or deleting a line of code in the file /usr/lib/pymodules/python2.7/openshot/windows/AddFiles.py or wherever that file is on your computer. Comment line 119:

  #set the last used folder
  preferences.Settings.app_state["import_folder"] = self.frmAddFiles.get_current_folder() <-- COMMENT THIS LINE OUT

  # clear and destroy this dialog

The problem apparently lies in gtk.FileChooserDialog.get_current_folder() returning None when it shouldn't, but that is over my head to fix.

Best regards,
ObsequiousNewt

The attachment "Fixed file" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

Patched /usr/lib/pymodules/python2.7/openshot/windows/AddFiles.py

I think I know where the issue is.
Apparently we did check if default_folder is "None" in lin 47 but the value of default_folder is None instead (None and not the string "None")

so if we change from:

  if default_folder != "None":
   self.frmAddFiles.set_current_folder(preferences.Settings.app_state["import_folder"])

to:
  if default_folder != None:
   self.frmAddFiles.set_current_folder(preferences.Settings.app_state["import_folder"])

the problem should be fix. Though I don't know whether or not there is a case where default_folder is "None", in that case we should check both.
In the first place, the issue only happen if you import files from "Recently Used" or something similar. A better fix might be to check if the current folder is None before assigning it to "import_folder".

My patch

I'm reluctant to apply this patch, because I can't reproduce the bug.

I am using Linux Mint 13 and the latest trunk source code. The Import files dialog opens ok no matter how many times I select the Import Files option.

I don't see any reason why. In any case, it's more understandable to check if a variable is None instead of "None".
The issue happen when I import files from "Recently Used" folder.
For some reason

self.frmAddFiles.get_current_folder()

return None. It could be because "Recently Used" is not an actual folder and the library did not handle it probably.
Then the value was assigned to

preferences.Settings.app_state["import_folder"]

without checking.
This cause undesirable problem afterward since the check fail to invalidate the None value.
The patch only remove the double quotes around "None", so no harm done I think.
If needed, you could change it to

if default_folder != None and default_folder != "None":

It can't be be bad to do more check.

Sincere

I confirm that bug.

Ubuntu 11.10 (Unity 2D session)
Openshot 1.4.0

1. press "Import file" button => select file dialog appears
2. selecting last file from "Recently used" (selecting file from filesystem directly does not triggers the bug)
3. file is imported to openshot project
4. press "Import file" button again => no file open dialog appears.

Andy, if you'd guide me a little about how to capture any logs that can help you - I can be of help either.

the workaround I use is to restart openshot

This bug has been fixed in version 1.4.3 of OpenShot.

https://bugs.launchpad.net/openshot/+bug/900796