project/series given to results2launchpad are overwritten by checkbox protocol deferred results

Bug #868305 reported by Sylvain Pineau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad Results
Fix Released
Low
Marc Tardif

Bug Description

I tried to submit results to a particular project to have the something similar to:
http://107.20.153.224/linuxmint

So I used my usual submission.xml like this:
results2launchpad --service-root=http://91.189.93.85/+api --credentials-file=/tmp/toto -s trunk sutton ./submission.xml

Unfortunately, even if the sutton projet exists in lp, my test run is recorded under ubuntu/natty.
It seems that DeferredSummary (launchpad-results/lib/lpresults/xunit/protocols/checkbox.py) overwrites the results2launchpad args.

Gary Poster (gary)
Changed in launchpad-results:
status: New → Triaged
importance: Undecided → High
Curtis Hovey (sinzui)
Changed in launchpad-results:
importance: High → Low
Revision history for this message
Marc Tardif (cr3) wrote :

Good point, the behavior reported in this bug was actually intentional but it would make more sense for the target project and series to be overwritable from the command line.

Revision history for this message
Marc Tardif (cr3) wrote :

The modified behavior is for the submission_prober script to use the project and series from the submission.xml file and for the resutls2launchpad tool to use those from the command line. The challenge was making it possible to use the same checkbox protocol for parsing the submission.xml file in both contexts. This was additionally a challenge because of the concept of DeferredProperty which proved to be an overly complex pattern to solve this problem and I'm sorry you had to wrap your brains around it. Instead, this has been replaced by a dispatcher capable of notifying listeners only when all events in a required set have been published. For example, only add devices when you have a system unit and a device otherwise, without a system unit, there's really no sense in attempting to add devices to nothing. Another advantage of this pattern is that parsing is done incrementally instead of parsing into an intermediate data structure before actually using the data.

The changes have been pushed to trunk and a new package is currently building, you will need to upgrade both python-lpresults and launchpad-results-tools to version 0.12. The production server will probably be updated by tomorrow. Please have a try and let me know if you can now specify a project and optional series on the command line.

Changed in launchpad-results:
assignee: nobody → Marc Tardif (cr3)
status: Triaged → Fix Committed
Marc Tardif (cr3)
Changed in launchpad-results:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.