IntegrityError: duplicate key value violates unique constraint "emailaddress__person__key"

... why does a login procedure end up calling a line like 'email.save()' ? That seems rather odd.

I guess it could be used to automatically mark which address is preferred, but that seems like a task better done in the session than in long-term storage.

It's part of long term storage because SSO needs to know which address to use when sending out emails.

The user can manually set which address is preferred... I'd rather set that once, manually, than have it change each time I log in (if I log in with a non-preferred address).

That's kind of tangential though. Not writing changes on login could maybe bypass the problem, but wouldn't actually fix the root cause.

The preferred address doesn't change if you log in using non-preferred one.

It's set only in case when there's no preferred email. In normally this is set by the user, via the web interface, and the login process doesn't need to touch it. Only in case when there's no such address (which is an exception, not the norm) the db is modified.

This is caused by the fact that there *is* a preferred email for this user, but it is linked to their lp_person and not to this account.

Fix is to check lp_person as well as account for preferred emails

Neat, sounds like it should be relatively easy to fix and will close a few tickets for me. :)

The fix committed fixed the reported case, but the same error was raised again with a more complex root cause: see 52679-2174canistelubuntu1983.oops

The new fix is more generic and *should* prevent this error from preventing login