Percona Toolkit moved to https://jira.percona.com/projects/PT

Document gdb dependency

Bug #856060 reported by Dario Minnucci
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Percona Toolkit moved to https://jira.percona.com/projects/PT
Fix Released
Low
Daniel Nichter
Percona Toolkit moved to https://jira.percona.com/projects/PT 2.1.4

Bug Description

Hi Daniel,

Please state somewhere in the documentation that 'gdb' is required for some tool in order to work.

$ grep -r "gdb " *
bin/pt-collect: gdb -ex "set pagination 0" -ex "thread apply all bt" --batch -p $p >> "$OPT_d/$d-stacktrace"
bin/pt-pmp: gdb -ex "set pagination 0" -ex "thread apply all bt" -batch -p $OPT_p >> "${OPT_k:-/tmp/percona-toolkit}"
blib/script/pt-pmp: gdb -ex "set pagination 0" -ex "thread apply all bt" -batch -p $OPT_p >> "${OPT_k:-/tmp/percona-toolkit}"
blib/script/pt-collect: gdb -ex "set pagination 0" -ex "thread apply all bt" --batch -p $p >> "$OPT_d/$d-stacktrace"
debian/percona-toolkit/usr/bin/pt-pmp: gdb -ex "set pagination 0" -ex "thread apply all bt" -batch -p $OPT_p >> "${OPT_k:-/tmp/percona-toolkit}"
debian/percona-toolkit/usr/bin/pt-collect: gdb -ex "set pagination 0" -ex "thread apply all bt" --batch -p $p >> "$OPT_d/$d-stacktrace"

Related branches

lp://staging/~percona-toolkit-dev/percona-toolkit/docu-gdp-dep
Daniel Nichter: Approve
Diff: 38 lines (+16/-2)
2 files modified
bin/pt-pmp (+3/-1)
bin/pt-stalk (+13/-1)
Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

Dario, gdb isn't required unless the -g option is used (pt-collect 1.0) or --collect-gdb (pt-stalk 2.0). It is, however, required by pt-pmp.

tags: added: docs
Changed in percona-toolkit:
importance: Undecided → Low
assignee: nobody → Daniel Nichter (daniel-nichter)
status: New → Confirmed
summary: - Please, document gdb dependency
+ Document gdb dependency
Revision history for this message
Baron Schwartz (baron-xaprb) wrote : Re: [Bug 856060] Please, document gdb dependency

It's not actually required by pt-pmp. This tool can be run against a file full of backtraces to format them nicely, independently of executing gdb to gather them. I don't think there should be a dependency for this; rather, the tool should just do something sensible like check for gdb if it's run in a mode that requires it.

Revision history for this message
Dario Minnucci (midget) wrote :

Hi guys,

I'm wasn't asking for an explicit dependecy here, only a hint on the tool documentation.

Sorry for the possible misunderstanding.

Revision history for this message
Baron Schwartz (baron-xaprb) wrote :

Thanks, and my apologies. I should have read the OP.

Daniel Nichter (daniel-nichter)
Changed in percona-toolkit:
milestone: none → 2.1.4
Daniel Nichter (daniel-nichter)
Changed in percona-toolkit:
status: Confirmed → In Progress
Daniel Nichter (daniel-nichter)
tags: added: pt-pmp pt-stalk
Changed in percona-toolkit:
status: In Progress → Fix Committed
Brian Fraser (fraserbn)
Changed in percona-toolkit:
status: Fix Committed → Fix Released
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-756

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.