Labels disappear after moving files to a folder or after an undo action

Bug #855824 reported by Joop Mevissen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenShot Video Editor
Fix Released
Medium
Jonathan Thomas

Bug Description

Ubuntu 11.04 (64-bit), Dutch language
Openshot 1.4.0-beta1 (latest trunk, revision 574)

Steps to reproduce:
1. Start OpenShot
2. Import several clips
3. Label some or all of the clips
4. Remove the last imported clip from the "Project files" tree
5. Press "Undo"

Result: all the labels of all the clips disappear

6. Label some or all of the clips again
7. Create one or more folders
8. Label the folder(s)
9. Move a clip to a folder

Result: labels of all the folders disappear

Same happens when you import a clip after labeling a folder

Traceback (most recent call last):
  File "/home/joop/Development/openshot/openshot/windows/TreeFiles.py", line 143, in cell_edited
    self.project.project_folder.UpdateFileLabel(unique_id, new_text, 0)
  File "/home/joop/Development/openshot/openshot/classes/files.py", line 507, in UpdateFileLabel
    if item.unique_id == unique_id:
AttributeError: OpenShotFolder instance has no attribute 'unique_id'

Related branches

Changed in openshot:
assignee: nobody → Jonathan Thomas (jonoomph)
importance: Undecided → Medium
milestone: none → 1.4.1
Revision history for this message
Jonathan Thomas (jonoomph) wrote :

This is now fixed in the trunk. Changing labels now updates the undo/redo history and marks the project as 'modified'. Also, folders were not setup correctly to handle labels. So, I fixed folders so they can now have labels. It all seems to work good now.

Changed in openshot:
status: New → Fix Committed
milestone: 1.4.1 → 1.4.0
Revision history for this message
Joop Mevissen (jm) wrote :

Thanks, works great!

However while I was testing this bug fix I found another bug: if you delete a folder and immediately import a new clip, the folder reappears. I'm not sure if it's related or not but I guess it has to do with the history.

Revision history for this message
Jonathan Thomas (jonoomph) wrote :

Woops... good catch. That is fixed now as well, and pushed to the trunk.

Andy Finch (fincha)
Changed in openshot:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.