FoxtrotGPS

Clicking on the "New Message arrived" indicator doesn't do anything

Bug #846801 reported by Joshua Judson Rosen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
FoxtrotGPS
Fix Released
Undecided
Joshua Judson Rosen

Bug Description

When new messages arrive through the friend-finder, the status-line changes to read "New Message arrived. Click here.".

If the info-pane is hidden, this does nothing but hide the message and allow the GPS status to reappear in the status-line.

Revision history for this message
Joshua Judson Rosen (rozzin) wrote :

Actually, *something* does happen: I get a warning from GObject:

    (foxtrotgps:6789): GLib-GObject-WARNING **: invalid cast from `GtkToolButton' to `GtkButton'

    (foxtrotgps:6789): Gtk-CRITICAL **: gtk_button_clicked: assertion `GTK_IS_BUTTON (button)' failed

Apparently, we're trying to call gtk_button_clicked() on the `info' button in the main toolbar, and that doesn't work because it's a GtkToolButton rather than a GtkButton. This may have changed/broken back when we moved from Marcus' original C-based GUI to libglade....

Luckily, the fix is easy--just emit a "clicked" signal directly with g_signal_emit_by_name().

Changed in foxtrotgps:
assignee: nobody → Joshua Judson Rosen (rozzin)
Joshua Judson Rosen (rozzin)
Changed in foxtrotgps:
status: New → In Progress
Revision history for this message
Joshua Judson Rosen (rozzin) wrote :

Fix committed to the trunk at revno:161, AKA
revid:<email address hidden>

Changed in foxtrotgps:
status: In Progress → Fix Committed
Joshua Judson Rosen (rozzin)
Changed in foxtrotgps:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.