UIFe: Spread - center the workspace switcher to account for the launcher and pane

Bug #837545 reported by John Lea
22
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ayatana Design
Fix Released
Medium
John Lea
Compiz
Fix Released
Medium
Unassigned
Compiz Main Plugins
Fix Released
Medium
Unassigned
compiz (Ubuntu)
Fix Released
Undecided
Unassigned
compiz-plugins-main (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

UIFE request - centre the workspace switcher to account for the launcher and panel, so that it does not appear offset.

Related branches

John Lea (johnlea)
Changed in ayatana-design:
assignee: nobody → John Lea (johnlea)
description: updated
tags: added: udo
Changed in ayatana-design:
importance: Undecided → Medium
status: New → Fix Committed
Changed in compiz-expo-plugin:
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → Sam Spilsbury (smspillaz)
Revision history for this message
John Lea (johnlea) wrote :

For Oneiric, the workspace spread should appear as shown in the attached screenshot. Note that this bug does not apply to 12.04

Revision history for this message
John Lea (johnlea) wrote :

Patch reviewed and approved by design for Oneiric UIFE.

Thanks Sam, great work ;-)

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Added updated screenshot to reflect recent changes to scaling algorithm

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

I might just comment on the various sections of the code that's changed in order to bring this to place and add a few rationales as to why we're doing this:

WHY WE'RE DOING THIS:
=====================

Partial implementations of what we want from the workspace switcher are already implemented in Unity-2D, such as the layout algorithm that it uses. In Unity-3D we're using the upstream Expo plugin for compiz which hasn't been given all that much attention lately, and it being used as a drop in replacement for what we actually want. Thankfully, the expo plugin is fairly easy to change and we can adapt what was given to us by upstream into something closer to the actual design downstream.

WHAT HAS CHANGED
======================
This branch changes the following things:
 * Inactive viewports have a dot-pattern displayed above them and are faded out and desaturated (30~ line change)
 * The selected viewport has a glow around it (imported logic from this from the group plugin, which has been well tested) (Add 300~ lines)
 * Click drag uses the XC_fleur cursor to have a "hand" dragging the window rather than an arrow. (4 line change)
 * Added X offset and Y offset options for the layout (20~ lines)
 * Changed option defaults

CONTINGENCY PLAN
======================
All of these things are implemented as options, if distro doesn't want them, you can turn the option down to its minimum value and there will be no change evident

DOCUMENTATION
======================
There is no change in behaviour, the only change that will be needed to make to documentation is that the selected viewport now has a glow around it instead of being not darkened and desaturated and screenshots will need to be updated

affects: compiz → ubuntu
affects: ubuntu → compiz (Ubuntu)
Revision history for this message
Jeremy Bícha (jbicha) wrote :

I agree that this doesn't have an impact on the current documentation, so from the Docs Team, I'm ok with this change which looks like it noticeably improves the workspace switcher. Thanks for the screenshots and text descriptions!

Revision history for this message
John Lea (johnlea) wrote :

@smspillaz; any word on when this change will land?

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

as soon as the release team acks it

Revision history for this message
Kate Stewart (kate.stewart) wrote :

If this change can be landed before beta 2 freeze, consider it acked. :)

If it can't be included before the freeze, I'd like to get pitti to comment on it, before we include it to make sure the other desktop considerations are understood.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in compiz (Ubuntu):
status: New → Confirmed
summary: - Spread - center the workspace switcher to account for the launcher and
- pane
+ UIFe: Spread - center the workspace switcher to account for the launcher
+ and pane
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package compiz - 1:0.9.5.94+bzr2803-0ubuntu4

---------------
compiz (1:0.9.5.94+bzr2803-0ubuntu4) oneiric; urgency=low

  * debian/profile_upgrades/com.canonical.unity.unity.02.upgrade:
    - upgrade the settings for the expo changes (LP: #837545)
  * debian/patches/01_ctrl_alt_*tea*.patch:
    - make Ctrl + Alt + T the default in compiz too as if you unity --reset
      to reset all the keys in gconf, it will revert the associated key
      for metacity in gnome-control-center
 -- Didier Roche <email address hidden> Thu, 15 Sep 2011 19:59:40 +0200

Changed in compiz (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package compiz-plugins-main - 1:0.9.5.94+bzr20110915-0ubuntu1

---------------
compiz-plugins-main (1:0.9.5.94+bzr20110915-0ubuntu1) oneiric; urgency=low

  * New upstream snapshot:
    - UIFe: Spread - center the workspace switcher to account for the
      launcher and pan (LP: #837545)
  * debian/patches/01-grid-fix-rev87.patch:
    - removed in upstream snapshot
 -- Didier Roche <email address hidden> Thu, 15 Sep 2011 19:59:56 +0200

Changed in compiz-plugins-main (Ubuntu):
status: New → Fix Released
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

It will be in the next upload

John Lea (johnlea)
Changed in ayatana-design:
status: Fix Committed → Fix Released
John Lea (johnlea)
tags: added: udp
Changed in ayatana-design:
status: Fix Released → Fix Committed
John Lea (johnlea)
Changed in ayatana-design:
status: Fix Committed → Fix Released
tags: added: reviewedbydesigno
removed: udo udp
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Fix missing upstream. Was only merged into an oneiric branch.

Changed in compiz-expo-plugin:
status: Fix Committed → Triaged
Changed in compiz-expo-plugin:
status: Triaged → In Progress
assignee: Sam Spilsbury (smspillaz) → Daniel van Vugt (vanvugt)
affects: compiz-expo-plugin → compiz-plugins-main
Changed in compiz-plugins-main:
assignee: Daniel van Vugt (vanvugt) → nobody
status: In Progress → Confirmed
Changed in compiz:
importance: Undecided → Medium
status: New → Confirmed
Changed in compiz-plugins-main:
status: Confirmed → Fix Released
Changed in compiz:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.