config files are read for each option
Bug #832042 reported by
Vincent Ladeuil
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Fix Released
|
High
|
Vincent Ladeuil | ||
Bug Description
This is bad for performance (especially for remote configs) and seen as a blocker to add more options.
It should be possible to read each config file once (and write it once if at least one option is modified/deleted) for a given bzr command.
Related branches
lp://staging/~vila/bzr/832042-shared-stores
- Martin Packman (community): Approve
-
Diff: 489 lines (+141/-56)13 files modifiedbzrlib/config.py (+62/-9)
bzrlib/library_state.py (+6/-0)
bzrlib/lockdir.py (+1/-1)
bzrlib/plugins/launchpad/test_register.py (+4/-0)
bzrlib/remote.py (+2/-2)
bzrlib/tests/__init__.py (+35/-29)
bzrlib/tests/blackbox/test_init.py (+4/-2)
bzrlib/tests/blackbox/test_serve.py (+2/-3)
bzrlib/tests/test_config.py (+9/-0)
bzrlib/tests/test_debug.py (+7/-4)
bzrlib/tests/test_lockdir.py (+1/-1)
bzrlib/tests/test_ui.py (+1/-2)
doc/en/release-notes/bzr-2.6.txt (+7/-3)
| Changed in bzr: | |
| assignee: | nobody → Vincent Ladeuil (vila) |
| importance: | Undecided → High |
| status: | New → Confirmed |
| tags: | added: config |
| Changed in bzr: | |
| status: | Confirmed → In Progress |
| Changed in bzr: | |
| assignee: | Vincent Ladeuil (vila) → nobody |
Revision history for this message
| Jelmer Vernooij (jelmer) wrote | #1 |
| Changed in bzr: | |
| assignee: | nobody → Vincent Ladeuil (vila) |
| Changed in bzr: | |
| milestone: | none → 2.6b3 |
| status: | In Progress → Fix Released |
| Changed in bzr: | |
| milestone: | 2.6b3 → 2.6.0 |
To post a comment you must log in.
Shouldn't this be tied to locking?