OpenQuake (deprecated)

Use logging.LoggerAdapter instead of "MDC" object to keep job_id in log records

Bug #827350 reported by Anton Gritsay on 2011-08-16

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenQuake (deprecated)	Won't Fix	Low	Anton Gritsay	OpenQuake (deprecated) 0.4.4

Bug Description

Instead of (not thread-safe) "MDC" object attached to handler class we may use standard way for that use-case: LoggerAdapter: http://docs.python.org/library/logging.html#loggeradapter-objects

Revision history for this message

Muharem Hrnjadovic (al-maisan) wrote on 2011-08-16:

Please see also https://bugs.launchpad.net/openquake/+bug/827349

Anton Gritsay (angri) on 2011-08-16

Changed in openquake:
assignee:	nobody → Anton Gritsay (angri)
status:	New → In Progress

Anton Gritsay (angri) on 2011-08-18

Changed in openquake:
importance:	Undecided → Low
milestone:	none → 0.4.3

John Tarter (toh2) on 2011-09-07

Changed in openquake:
milestone:	0.4.3 → 0.4.4

John Tarter (toh2) on 2011-10-04

Changed in openquake:
milestone:	0.4.4 → 0.4.5

Revision history for this message

Anton Gritsay (angri) wrote on 2011-10-04:

That appeared to be bad idea after all. The requirement (access to job id in log records) was achieved with "MDC" in handler class (the way it used to be).

Changed in openquake:
milestone:	0.4.5 → 0.4.4
status:	In Progress → Won't Fix

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.