Segmentation fault when closing MIxxx with a running Rhythmbox import

Presumably we will need a similar fix for iTunes and Traktor, since they are implemented in the same way as Rhythmbox.

Daniel -- what about the following patch that just calls QFuture::cancel() and QFuture::waitForFinished() ? Could you test that this also fixes the segfault? I can't really reproduce since my imports go too quickly.

I think I prefer to just wait for the import to finish instead of threading a cancel boolean into the worker thread.

Daniel -- what about the following patch that just calls QFuture::cancel() and QFuture::waitForFinished() ? Could you test that this also fixes the segfault? I can't really reproduce since my imports go too quickly.

I think I prefer to just wait for the import to finish instead of threading a cancel boolean into the worker thread.

Hmm -- nevermind I see that QFuture's run via QtConcurrent::run() cannot be cancelled. Just the same, waiting for the future to finish should work fine -- right?

Hi RJ, when I was originally working on that bug, I had the same thoughts. I have pick the solution with the cancel boolean because on my netbook with a big Rhythmbox library, the import took about a minute and it is hard to explain, why the user should wait so long for building a temporary table when closing mixxx.

Daniel -- sounds good. I agree that not waiting is better if the import
takes a while. I'll fix up something similar for iTunes and Traktor then
commit your patch.

Thanks,
RJ

2011/10/14 Daniel Schürmann <email address hidden>

> Hi RJ, when I was originally working on that bug, I had the same
> thoughts. I have pick the solution with the cancel boolean because on my
> netbook with a big Rhythmbox library, the import took about a minute and
> it is hard to explain, why the user should wait so long for building a
> temporary table when closing mixxx.
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/824171
>
> Title:
> Segmentation fault when closing MIxxx with a running Rhythmbox import
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/824171/+subscriptions
>

Thanks Daniel -- committed your patch and added similar protection for iTunes and Traktor.

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5964