Checkbox

storage tests are running against MMC readers still on Oneiric Alpha 3

Bug #822948 reported by Jeff Lane 
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox
Fix Released
High
Marc Tardif
Checkbox 0.12.7 "oneiric_fixes_2"

Bug Description

Running checkbox on Oneiric alpha 3 and I noticed that the storage tests (storage_device_*, disk_smart_* and benchmark_*) are running against the MMC reader on the Latitude 2120.

I thought we'd fixed this... but it needs to be fixed somehow. Running these tests against non-existant devices wastes testers time, and also provides false feedback when the tester gets a message that storage_device_sdb failed (when sdb doesn't actually exist).

Tags: oneiric

Related branches

lp://staging/~cr3/checkbox/822948
Brendan Donegan (community): Approve
Diff: 79 lines (+18/-5)
2 files modified
checkbox/parsers/udev.py (+16/-4)
debian/changelog (+2/-1)
lp://staging/~roadmr/ubuntu/oneiric/checkbox/0.12.7
Daniel Holbach: Needs Information
Diff: 8336 lines (+2048/-1194)
32 files modified
checkbox/job.py (+9/-0)
checkbox/lib/transport.py (+26/-1)
checkbox/parsers/udev.py (+16/-4)
checkbox/report.py (+39/-12)
checkbox/tests/report.py (+1/-1)
checkbox/variables.py (+1/-1)
checkbox_gtk/gtk_interface.py (+6/-5)
checkbox_gtk/hyper_text_view.py (+3/-1)
data/whitelists/default.whitelist (+1/-0)
debian/changelog (+27/-0)
debian/control (+2/-2)
debian/po/it.po (+17/-9)
jobs/disk.txt.in (+1/-1)
jobs/info.txt.in (+9/-0)
jobs/mediacard.txt.in (+1/-1)
jobs/memory.txt.in (+2/-2)
jobs/monitor.txt.in (+1/-1)
jobs/suspend.txt.in (+2/-2)
plugins/intro_prompt.py (+2/-4)
plugins/jobs_prompt.py (+5/-0)
plugins/launchpad_prompt.py (+2/-2)
plugins/launchpad_report.py (+25/-18)
plugins/recover_prompt.py (+1/-2)
plugins/report_prompt.py (+7/-0)
plugins/suites_prompt.py (+2/-3)
po/es.po (+91/-92)
po/hu.po (+230/-209)
po/it.po (+588/-363)
po/zh_CN.po (+250/-233)
po/zh_TW.po (+147/-224)
report/hardware-1_0.rng (+533/-0)
scripts/gconf_resource (+1/-1)
lp://staging/ubuntu/oneiric/checkbox
Revision history for this message
Jeff Lane  (bladernr) wrote :

Marked High because we need to get this fixed before freeze.

Changed in checkbox:
importance: Undecided → High
Jeff Lane  (bladernr)
tags: added: oneiric
Ara Pulido (ara)
Changed in checkbox:
assignee: nobody → Canonical Hardware Certification (canonical-hw-cert)
milestone: none → 0.12.6
status: New → Triaged
Marc Tardif (cr3)
Changed in checkbox:
assignee: Canonical Hardware Certification (canonical-hw-cert) → Marc Tardif (cr3)
Revision history for this message
Marc Tardif (cr3) wrote :

First, this problem seems to be specific to the 10ec:5208 PCI device which has an explicit udev rule to set the ID_DISK_FLASH environment variable. The problem with detecting this variable is that it is only defined for the block which is a child of the actual physical device. Since the udev parser reads the output of udevadm as a stream, state must somehow be preserved between devices. In other words, somekind of support needs to be added for the attributes of a device to be gathered across multiple parts of the udevadm output.

Marc Tardif (cr3)
Changed in checkbox:
status: Triaged → In Progress
Marc Tardif (cr3)
Changed in checkbox:
status: In Progress → Fix Committed
Marc Tardif (cr3)
Changed in checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.