OpenShot Video Editor

Right clicking unselected items

Bug #821380 reported by Berg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenShot Video Editor
Fix Released
Medium
Unassigned
OpenShot Video Editor 1.4.0

Bug Description

1) Ubuntu 11.04
2) PPA
3) 1.3.1

Steps to reproduce:
1) Start OpenShot.
2) Import some clips.
3) Make sure no clip is selected. (Background should not be dark blue behind any of the clips)
4) Right click on one of the clips and see that a menu intended for the background is shown. The clip remains unselected.
5) To show the correct menu, the clips must first be selected by left clicking. The behaviour is the same regardless if you are in "Detail View" or in "Thumbnail View".

What should happen:
The clip should automatically be selected when right clicked.

Patch below. The patch also fixes two other minor issues:
1) A video with a length of exactly 300.0 seconds could, at least in theory, be treated as an an image when dragged onto the timeline.
2) The turn on/off audio and video buttons on the left of the tracks could be right clicked.

Revision history for this message
Berg (emil-berg91) wrote :
Revision history for this message
Berg (emil-berg91) wrote :

Sorry. I just realized that the patch broke the "Add Many Clips to the timeline in 1 step" feature. Don't use the patch (changes8.patch). I'll post a new later.

Revision history for this message
Olivier Girard (eolinwen) wrote :

Hi,
Okay, we 'll wait until the new patch will come. when it 'll be okay, I'll put in the next milestone.
Thanks a lot for your participation.

Revision history for this message
Berg (emil-berg91) wrote :

New patch. Tested and seems to work fine for both thumbnail and detail view. Holds the same changes as the patch before, but now selection of several clips work.

Olivier Girard (eolinwen)
Changed in openshot:
importance: Undecided → Low
milestone: none → 1.4.0
Revision history for this message
Andy Finch (fincha) wrote :

Hi Emil, I have applied the main part of the patch, I had to change it slightly as when selecting one of the menu items the model appeared to be missing. Perhaps you can double check what I have applied to the trunk works ok for you.

I haven't applied the part regarding the image length, as there is actually a request to remove the 300 second limitation and make it longer. The other part regarding the audio/video buttons is already applied. Thanks!

Changed in openshot:
status: New → Fix Committed
Revision history for this message
Berg (emil-berg91) wrote :

That's right. In iconview (thumbnail view) an error occured when right clicking a file. I somehow missed that. Your fix seems to work.
Thanks!

Jonathan Thomas (jonoomph)
Changed in openshot:
importance: Low → Medium
Andy Finch (fincha)
Changed in openshot:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.