machine_data is a formless blob
Bug #820892 reported by
William Reade
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| pyjuju |
Fix Released
|
Undecided
|
William Reade | ||
Bug Description
When telling a provider to launch a machine, we generally specify one piece of data (the machine id) in a dictionary which gets passed around and expanded and rearranged before ending up passed into a function named format_cloud_init. We need to impose some structure on this process, and differentiate between the data required for cloud_init, the additional user data that piggybacks on cloud_init, and any other keys that aren't useful at all and just come along for the ride.
Related branches
lp://staging/~fwereade/pyjuju/cloud-init-class-used
- Kapil Thangavelu (community): Approve
- Gustavo Niemeyer: Approve
-
Diff: 2107 lines (+514/-880)28 files modifiedensemble/providers/common/base.py (+3/-4)
ensemble/providers/common/cloudinit.py (+12/-13)
ensemble/providers/common/launch.py (+46/-170)
ensemble/providers/common/tests/data/cloud_init_bootstrap (+1/-2)
ensemble/providers/common/tests/data/cloud_init_bootstrap_zookeepers (+1/-2)
ensemble/providers/common/tests/data/cloud_init_branch (+1/-2)
ensemble/providers/common/tests/data/cloud_init_distro (+1/-2)
ensemble/providers/common/tests/data/cloud_init_normal (+1/-2)
ensemble/providers/common/tests/test_bootstrap.py (+102/-0)
ensemble/providers/common/tests/test_cloudinit.py (+2/-2)
ensemble/providers/common/tests/test_launch.py (+61/-224)
ensemble/providers/common/tests/test_utils.py (+1/-2)
ensemble/providers/common/utils.py (+3/-3)
ensemble/providers/ec2/__init__.py (+10/-5)
ensemble/providers/ec2/launch.py (+32/-53)
ensemble/providers/ec2/tests/common.py (+2/-4)
ensemble/providers/ec2/tests/data/bootstrap_cloud_init (+18/-0)
ensemble/providers/ec2/tests/data/launch_cloud_init (+15/-0)
ensemble/providers/ec2/tests/test_bootstrap.py (+16/-51)
ensemble/providers/ec2/tests/test_launch.py (+79/-114)
ensemble/providers/ec2/tests/test_utils.py (+40/-106)
ensemble/providers/ec2/utils.py (+17/-69)
ensemble/providers/orchestra/__init__.py (+9/-6)
ensemble/providers/orchestra/launch.py (+23/-34)
ensemble/providers/orchestra/tests/common.py (+2/-1)
ensemble/providers/orchestra/tests/data/bootstrap_late_command (+5/-5)
ensemble/providers/orchestra/tests/data/launch_late_command (+5/-4)
ensemble/providers/orchestra/tests/test_launch.py (+6/-0)
| Changed in ensemble: | |
| assignee: | nobody → William Reade (fwereade) |
| milestone: | none → dublin |
| Changed in ensemble: | |
| milestone: | dublin → eureka |
| Changed in ensemble: | |
| status: | New → In Progress |
| Changed in ensemble: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
