FileStorage interface is inconsistent
Bug #817736 reported by
William Reade
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| pyjuju |
Fix Released
|
Undecided
|
William Reade | ||
Bug Description
The ec2 implementation had diverged from the docs and from the dummy implementation; the fact that the docs and the implementation disagree as to the return type of .get() doesn't help. Ideally, we should get() the same type as we put(), and we should make sure all implementations of this interface match. (Static typing? What's that?)
Related branches
lp://staging/~fwereade/pyjuju/storage-file-objects
- Kapil Thangavelu (community): Approve
- Gustavo Niemeyer: Approve
-
Diff: 465 lines (+84/-90)9 files modifiedensemble/formula/publisher.py (+22/-17)
ensemble/formula/tests/test_publisher.py (+19/-2)
ensemble/ftests/test_ec2_provider.py (+5/-6)
ensemble/providers/dummy.py (+5/-9)
ensemble/providers/ec2/files.py (+11/-15)
ensemble/providers/ec2/tests/test_files.py (+3/-21)
ensemble/providers/ec2/tests/test_launch.py (+1/-2)
ensemble/providers/tests/test_dummy.py (+16/-18)
ensemble/state/tests/test_utils.py (+2/-0)
| Changed in ensemble: | |
| status: | New → In Progress |
| assignee: | nobody → William Reade (fwereade) |
| milestone: | none → dublin |
| Changed in ensemble: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
