Client will not disconnect quickly if the connection is lost
Bug #816137 reported by
Facundo Batista
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu One Client |
Fix Released
|
Critical
|
Facundo Batista |
Bug Description
Since Natty (AFAIK) when the connection is lost, Twisted takes too long to notice.
For example, consider the following situation: you sleep your computer, and wake it up one hour again... the server already closed the connection for your client (it has its own timeout), and the client tries to do a Ping to the server, or do any operation, but the connection is down.
Previously, Twisted will raise connectionLost on the first usage in this case, but now it does it after 30 minutes.
So, the client needs to implement its own timeout, and raise connectionLost if the "ping" is not answered in 3 minutes.
Related branches
lp://staging/~facundo/ubuntuone-client/ping-timeout
- dobey (community): Approve
-
Diff: 324 lines (+180/-60)2 files modifiedtests/syncdaemon/test_action_queue.py (+131/-46)
ubuntuone/syncdaemon/action_queue.py (+49/-14)
Changed in ubuntuone-client: | |
status: | Triaged → In Progress |
Changed in ubuntuone-client: | |
status: | In Progress → Fix Committed |
Changed in ubuntuone-client: | |
milestone: | none → 1.7.1 |
Changed in ubuntuone-client: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.