Launchpad itself

Inline diffs in merge proposals don't have a spinner when it's waiting for the diff

Bug #814697 reported by Julian Edwards
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Richard Harding

Bug Description

The page looks idle until the diff data suddenly appears. It should have a spinner.

Related branches

lp://staging/~rharding/launchpad/bug_814697_missing_spinner
Graham Binns (community): Approve (code)
Diff: 14 lines (+1/-1)
1 file modified
lib/lp/code/templates/branch-macros.pt (+1/-1)
Julian Edwards (julian-edwards)
Changed in launchpad:
status: New → Triaged
importance: Undecided → High
tags: added: code-review trivial ui
Revision history for this message
Nigel Babu (nigelbabu) wrote :

Julian, I can duplicate this. Potential candidate for closing?

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Go for it.

Richard Harding (rharding)
Changed in launchpad:
assignee: nobody → Richard Harding (rharding)
status: Triaged → In Progress
Revision history for this message
Richard Harding (rharding) wrote :

Tested and spinner shows at the end of the link while loading. Closing.

Changed in launchpad:
status: In Progress → Invalid
Revision history for this message
Richard Harding (rharding) wrote :

marking incomplete since we can't reproduce, add notes and details if you still see it and I'll look at it.

Changed in launchpad:
status: Invalid → Incomplete
Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 814697] Re: Inline diffs in merge proposals don't have a spinner when it's waiting for the diff

  status triaged

I can reproduce this 100% of the time on oneiric chromium: go to eg
https://code.launchpad.net/~mbp/launchpad/808282-canonical-url/+merge/82811
and click "Changes added by revision". There is "loading" text" but
no spinner.

same on firefox for that matter.

Changed in launchpad:
status: Incomplete → Triaged
Richard Harding (rharding)
Changed in launchpad:
status: Triaged → In Progress
Revision history for this message
Richard Harding (rharding) wrote :

The current spinner we have is on a white background and this needs it to show up ok on a grey background. I'll work on seeing if we can get an updates spinner before going forward, but attached the branch with a change to add it.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r14365 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14365>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Richard Harding (rharding)
tags: added: qa-ok
removed: qa-needstesting
Raphaël Badin (rvb)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.