Misuses bzr 2.4's new set_commit_message hook to disable editor prompting for a commit message entirely

Bug #812749 reported by Max Bowsher
36
This bug affects 5 people
Affects Status Importance Assigned to Milestone
bzr-builddeb
Fix Released
High
Max Bowsher

Bug Description

bzr-builddeb is misusing bzr 2.4's new set_commit_message hook to disable editor prompting for a commit message entirely. It really shouldn't be doing this.

Revision history for this message
James Westby (james-w) wrote : Re: [Bug 812749] [NEW] Misuses bzr 2.4's new set_commit_message hook to disable editor prompting for a commit message entirely

On Tue, 19 Jul 2011 08:30:21 -0000, Max Bowsher <email address hidden> wrote:
> Public bug reported:
>
> bzr-builddeb is misusing bzr 2.4's new set_commit_message hook to
> disable editor prompting for a commit message entirely. It really
> shouldn't be doing this.

Was this done for the bug properties to be set?

Is there a way to still do that but to prompt with a suggested message
as it did before?

Thanks,

James

Revision history for this message
Jonathan Riddell (jr) wrote :

The idea is to replace debcommit which commits with the message from debian/changelog without prompting. This is the behaviour most packagers are used to.

Jelmer Vernooij (jelmer)
Changed in bzr-builddeb:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Max Bowsher (maxb) wrote :

Developers may be used to debcommit not giving them a chance to edit the commit message.

They are NOT used to 'bzr ci' not giving them a chance to edit the commit message, and I would hotly dispute that 'bzr ci' needs to become an exact equivalent to debcommit. And if it does, then it needs an -e/--edit option like debcommit has.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

It should be possible to work around this by disabling the bzr-builddeb plugin during commit:

BZR_DISABLE_PLUGINS=builddeb bzr commit

Changed in bzr-builddeb:
status: Triaged → Fix Committed
assignee: nobody → Max Bowsher (maxb)
Jelmer Vernooij (jelmer)
Changed in bzr-builddeb:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.