inconvenient EC2Operation inheritance
Bug #809005 reported by
William Reade
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| pyjuju |
Fix Released
|
Undecided
|
William Reade | ||
Bug Description
many classes inherit from EC2Operation for convenience' sake, but this makes some refactorings hard. We should remove EC2Operation, and thereby let EC2LaunchMachine depend on EC2ZookeeperAware via composition rather than inheritance.
Related branches
lp://staging/~fwereade/pyjuju/break-zkaw-links
- Kapil Thangavelu (community): Approve
- Gustavo Niemeyer: Approve
-
Diff: 440 lines (+64/-68)7 files modifiedensemble/providers/ec2/accessor.py (+2/-3)
ensemble/providers/ec2/connect.py (+10/-5)
ensemble/providers/ec2/iterate.py (+7/-5)
ensemble/providers/ec2/launch.py (+26/-23)
ensemble/providers/ec2/operation.py (+0/-16)
ensemble/providers/ec2/shutdown.py (+4/-5)
ensemble/providers/ec2/state.py (+15/-11)
| Changed in ensemble: | |
| assignee: | nobody → William Reade (fwereade) |
| milestone: | none → dublin |
| status: | New → In Progress |
| Changed in ensemble: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
