get_share_path should not have a platform dependent implementation
Bug #807235 reported by
Natalia Bidart
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu One Client |
Fix Released
|
High
|
Natalia Bidart | ||
Bug Description
On one hand, the get_share_path method has a misleading name, it should be called get_share_dir_name. And the implementation is not platform dependent, so we need to move it to volume_manager.
Related branches
lp://staging/~nataliabidart/ubuntuone-client/fix-807235
- Manuel de la Peña (community): Approve
- Roberto Alsina (community): Approve (code review only)
-
Diff: 466 lines (+92/-143)8 files modifiedtests/platform/linux/test_vm.py (+1/-26)
tests/platform/windows/test_vm_helper.py (+3/-26)
tests/syncdaemon/test_vm.py (+44/-17)
ubuntuone/platform/linux/__init__.py (+0/-1)
ubuntuone/platform/linux/vm_helper.py (+0/-32)
ubuntuone/platform/windows/__init__.py (+0/-1)
ubuntuone/platform/windows/vm_helper.py (+1/-32)
ubuntuone/syncdaemon/volume_manager.py (+43/-8)
| Changed in ubuntuone-client: | |
| assignee: | nobody → Natalia Bidart (nataliabidart) |
| status: | New → In Progress |
| importance: | Undecided → High |
| tags: | added: u1-zomg-windows |
| Changed in ubuntuone-client: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntuone-client: | |
| milestone: | none → 1.7.1 |
| Changed in ubuntuone-client: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
