GNU Mailman REST Client

Add c.get_domain() by web_host and not only mail_host

Bug #802540 reported by benste
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNU Mailman
Confirmed
Low
Unassigned
GNU Mailman REST Client
Fix Committed
Undecided
benste
GNU Mailman REST Client 1.0.0a1

Bug Description

Add additional steps to get a domain by it's web_host and not only by it's mail_host
this will be neccessary when adding a choice field which should list all lists on your current domain you're browsing.

e.g mail.example.com || example.com

Tags: mailman3
Revision history for this message
benste (benste) wrote :

I'd suggest iterating all available domains for it's web_host atribute and reutrn the proper domain object based on the parents mail_host

benste (benste)
Changed in mailman.client:
assignee: nobody → benste (benste)
benste (benste)
Changed in mailman.client:
status: New → Fix Committed
Barry Warsaw (barry)
Changed in mailman:
status: New → Confirmed
milestone: none → 3.0.0a8
Revision history for this message
benste (benste) wrote :

barry do you prefer to change this in the core ?
Flo told me that SQL querriys might me much faster.

Revision history for this message
Barry Warsaw (barry) wrote :

In general, when there's important functionality missing in the client, I think it's at least worth considering whether to add it in the core. For example, if other (i.e. non-Python) REST clients might want the same functionality, let's push it into the core.

It's fine to add a workaround in mailman.client first, as long as the API doesn't change once the core adds functionality. In that case, you'll be able to just change the implementation to the more efficient, core version, without code using the client library having to change.

When that's the case, it's fine to add a mailman bugtask and a mailman3 tag.

tags: added: mailman3
Barry Warsaw (barry)
Changed in mailman:
milestone: 3.0.0a8 → none
Barry Warsaw (barry)
Changed in mailman:
importance: Undecided → Low
Florian Fuchs (flo-fuchs)
Changed in mailman.client:
milestone: none → 1.0.0a1
Revision history for this message
Abhilash Raj (raj-abhilash1) wrote :

This bug has been moved to the new gitlab repo here: https://gitlab.com/mailman/mailman/issues/28

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.