Set lifetime for input forms
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
GNU Mailman |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
We may have to set lifetime for input forms because of recent activities on cross-site request forgery (CSRF). The form lifetime is successfully deployed in frameworks like web.py or plone etc. Proposed branch lp:~tkikuchi/mailman/form-lifetime implement lifetime in admin, admindb, options and edithtml interfaces. Other forms like create and rmlist have confirmation by password thus are safe regarding CSRF. The form generation time is set by a hidden parameter whose value is calculated following the mailman cookie algorithm. The default lifetime is set 1 hour in Default.py thus configurable by a site administrator. If a password is set in request, authorization cookie is discarded so the password authentication is forced. Wget tricks to manage list in FAQ can be used as they are now.
Related branches
- Mark Sapiro: Pending requested
-
Diff: 429 lines (+190/-12)8 files modifiedMailman/CSRFcheck.py (+73/-0)
Mailman/Cgi/admin.py (+24/-5)
Mailman/Cgi/admindb.py (+22/-2)
Mailman/Cgi/edithtml.py (+22/-2)
Mailman/Cgi/options.py (+27/-1)
Mailman/Defaults.py.in (+3/-0)
Mailman/HTMLFormatter.py (+8/-1)
Mailman/htmlformat.py (+11/-1)
CVE References
Changed in mailman: | |
status: | New → Fix Committed |
Changed in mailman: | |
status: | Fix Committed → Fix Released |
information type: | Private Security → Public |
Changed in mailman: | |
milestone: | 2.1.15 → 2.1.23 |
The lp:~tkikuchi/mailman/form-lifetime branch was only partially merged fo Mailman 2.1.15. It has now been completely merged for Mailman 2.1.23.