generate-contents-files.py ignores the release pocket

As it turns out, it's not the split() that does it. LpQueryDistro deliberately doesn't even return the empty pocket suffix.

Disaster strikes in this bit of shell script that I converted incorrectly:

# Combine all supported series with all pocket suffixes to build the list
# of suites for which we will generate/update Contents.gz.
new_suites=
for suite in $suites; do
  new_suites="${new_suites:+$new_suites }$suite"
  for pocket_suffix in $pocket_suffixes; do
    if [ -d "$ARCHIVE/ubuntu/dists/$suite$pocket_suffix" ]; then
      new_suites="$new_suites $suite$pocket_suffix"
    fi
  done
done
suites="$new_suites"

This adds the $suite to $new_suites, and then for each non-empty pocket suffix adds $suite$pocket_suffix to $new_suites.

One simple fix is to go into lp.archivepublisher.scripts.generate_contents_files.GenerateContentsFiles and make getPocketSuffixes return pocketsuffix.values() instead of building it in top of queryDistro. That'll be another pain point when we make pockets dynamic, but that's a drop in a bucket.

Fixed in db-stable r10485 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/10485>.