loggerhead

Loggerhead does not tell users how to branch

Bug #770432 reported by Curtis Hovey
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
loggerhead
Fix Released
High
Unassigned

Bug Description

When displaying a branch, loggerhead helpfully displays the following message:

To get this branch, use:
bzr branch /folder/trunk

It should say:
bzr branch lp:<project>
or
bzr branch lp:<project>/<series>
or
bzr branch lp:<user>/<project>/<branch-name>

Revision history for this message
John A Meinel (jameinel) wrote :

This is done via the "public_branch=" setting, or via BranchWSGIApp(served_url=XXX) parameter.

Note that I do not see that simple message here:
http://bazaar.launchpad.net/~loggerhead-team/loggerhead/trunk-rich/changes

Though I do see it if I do "bzr serve --http" (though I have public_branch= set for myself)

If Launchpad is passing "served_url=None" then the message should be suppressed completely.

Otherwise if served_url is not being set, and public_branch is not set, then it tries to work out what URL it is serving and supply that (self.served_url = self.url([]))

I don't really see how '/folder/trunk' would get set without someone doing that manually.

j.c.sackett (jcsackett)
Changed in loggerhead:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Robert Collins (lifeless) wrote :

Curtis, could you supply a url showing the fault?

summary: - Logger head does not tell users how to branch
+ Loggerhead does not tell users how to branch
Changed in loggerhead:
status: Triaged → Incomplete
Revision history for this message
Curtis Hovey (sinzui) wrote :

This was shown on the revision and changelog views. The template branchinfo.pt still exists, but I I think it was superseded bu a macro function that looks for branch.served_url. I do not think Lp is configured to have a branch.server_url, it would be passed to BranchWSGIApp because we have a test that says we do not show it.

Changed in loggerhead:
status: Incomplete → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.