Add Adblock toggle to statusbar
Bug #768568 reported by
Cris Dywan
This bug affects 10 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Midori Web Browser |
Fix Released
|
High
|
Unassigned |
Bug Description
When using Adblock it can be useful to temporarily turn it off when experiencing problems on a site. Since extensions are inside the Preferences dialogue now it is more cumbersome to do so.
There should be a button created by Adblock that sits in the statusbar. There is some code creating an image already, which was never finished, it can be replaced with a GtkTogglebutton, maybe an error icon for the icon, and add a boolean setting to the extension that is checked in the callback that blocks sites.
Related branches
lp://staging/~midori/midori/adblock-icon
- Midori Devs: Pending requested
-
Diff: 372 lines (+289/-3)6 files modifieddata/adblock/adblock-disabled.svg (+46/-0)
data/adblock/adblock-enabled.svg (+80/-0)
data/adblock/adblock-enabled2.svg (+46/-0)
data/adblock/adblock-symbolic.svg (+46/-0)
extensions/adblock/config.vala (+7/-1)
extensions/adblock/extension.vala (+64/-2)
lp://staging/~midori/midori/addingDefaultsAndFilters
- Cris Dywan: Approve
-
Diff: 1852 lines (+1095/-298)14 files modifieddata/adblock.list (+1/-0)
data/adblock/blocked.svg (+46/-0)
data/adblock/disabled.svg (+46/-0)
data/adblock/enabled.svg (+80/-0)
extensions/adblock/config.vala (+78/-39)
extensions/adblock/extension.vala (+421/-210)
extensions/adblock/subscriptions.vala (+48/-10)
extensions/adblock/updater.vala (+47/-31)
extensions/adblock/widgets.vala (+310/-0)
katze/midori-paths.vala (+12/-4)
midori/midori-app.c (+1/-1)
midori/midori-browser.c (+1/-1)
midori/midori-download.vala (+3/-2)
po/POTFILES.in (+1/-0)
Changed in midori: | |
importance: | Undecided → High |
status: | New → Confirmed |
tags: |
added: bitesize removed: bitsize |
Changed in midori: | |
assignee: | natano (natanoptacek) → nobody |
Changed in midori: | |
status: | Confirmed → In Progress |
milestone: | none → 0.5.8 |
Changed in midori: | |
status: | In Progress → Fix Committed |
Changed in midori: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The patch implements a toggle button for adblock (can be enabled/disabled per tab). The patch still needs some work, but it would be nice to get some preliminary feedback, especially if a per tab toggle is wanted.