Incorrect non-ajax url for vocabulary popup pickers
Bug #761331 reported by
Ian Booth
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Ian Booth | ||
Bug Description
When a popup picker widget is rendered, you get a text field for direct entry of the value plus a link to invoke the popup to choose a value from a defined vocabulary. Where javascript is not available, there is supposed to be a non-ajax link that is rendered. This link is hard coded to "/people/" which is correct for a people picker but incorrect for a bug tracker picker for example. The code which renders the link needs to use the nonajax_uri property for the link.
Related branches
lp://staging/~wallyworld/launchpad/refactor-picker-template
- Brad Crittenden (community): Approve (code)
-
Diff: 486 lines (+176/-155)12 files modifiedlib/lp/answers/stories/question-browse-and-search.txt (+2/-2)
lib/lp/app/configure.zcml (+1/-0)
lib/lp/app/widgets/configure.zcml (+6/-0)
lib/lp/app/widgets/popup.py (+24/-71)
lib/lp/app/widgets/templates/bugtracker-picker.pt (+41/-0)
lib/lp/app/widgets/templates/form-picker-macros.pt (+71/-0)
lib/lp/app/widgets/templates/form-picker.pt (+7/-17)
lib/lp/app/widgets/templates/vocabulary-picker.js.template (+0/-47)
lib/lp/app/widgets/tests/test_popup.py (+16/-14)
lib/lp/app/widgets/tests/test_suggestion.py (+5/-1)
lib/lp/bugs/stories/bug-also-affects/xx-also-affects-new-upstream.txt (+1/-1)
lib/lp/bugs/stories/bugs/xx-front-page-search.txt (+2/-2)
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| Changed in launchpad: | |
| milestone: | none → 11.05 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r12848 <http://