FORMULA_DIR should be available to hooks
Bug #761015 reported by
Kapil Thangavelu
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| pyjuju |
Fix Released
|
Medium
|
Kapil Thangavelu | ||
Bug Description
Hooks should be able to rely on bundled binaries/libraries in the formula, without the directory passed, they might easily know where to find them.
Related branches
lp://staging/~hazmat/pyjuju/hooks-with-formula-dir
- William Reade (community): Approve
- Gustavo Niemeyer: Approve
- Jim Baker: Pending requested
-
Diff: 271 lines (+82/-15)6 files modifieddocs/source/faq.rst (+7/-0)
ensemble/hooks/invoker.py (+11/-2)
ensemble/hooks/tests/test_executor.py (+9/-3)
ensemble/hooks/tests/test_invoker.py (+46/-6)
ensemble/unit/lifecycle.py (+5/-3)
ensemble/unit/tests/test_lifecycle.py (+4/-1)
Revision history for this message
| Kapil Thangavelu (hazmat) wrote | #1 |
| Changed in ensemble: | |
| milestone: | none → budapest |
Revision history for this message
| Gustavo Niemeyer (niemeyer) wrote | #2 |
| summary: |
- FORMULA_DIRECTORY should be available to hooks + FORMULA_DIR should be available to hooks |
| Changed in ensemble: | |
| milestone: | budapest → dublin |
| Changed in ensemble: | |
| importance: | Undecided → Medium |
| Changed in ensemble: | |
| assignee: | nobody → Kapil Thangavelu (hazmat) |
| Changed in ensemble: | |
| status: | New → In Progress |
| Changed in ensemble: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
actually this might be better done as just making $CWD be the formula directory when running the hook.