Templates broken after django-web-themes added a light/404.html

Bug #747340 reported by Michael Nelson
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ratings and Reviews server
Fix Released
Low
Michael Nelson
Software Center Agent
Fix Released
Low
Michael Nelson

Bug Description

django-web-themes recently got a light/404.html which is found by our django whenever a 404 is raised (as we have /path/to/web-themes/light/ on the list of template_dirs).

The problem is that light/404.html extends light/index.1col.html which is not found and so our tests fail.

I chatted with mhall119 about it, and the intended way of using the light web theme is for us to use "/path/to/web-themes/" in the template dirs, and then our own 404.html can simply inherit from the light/404.html one.

For us to do this requires a tiny patch to light/404.html so that we can include the extra oops info.

Note: When this fix is going to be deployed, we need to
1) update our configs on both projects with the new config schema option for preflight_base_template (see MPs)
2) Update the template_dirs on the configs (removing the 'light/')
3) Update the templates/404.html and /500.html in the rnr configs (in the same way as the django_project/templates the rnr MP below - maybe we should just move them on trunk into src/sca/templates so we don't need the duplication)

Tags: kb-defect sp-1

Related branches

summary: - Tests failing after django-web-themes added a light/404.html
+ Templates broken after django-web-themes added a light/404.html
tags: added: kb-task
Changed in rnr-server:
assignee: nobody → Michael Nelson (michael.nelson)
importance: Undecided → Low
status: New → In Progress
Changed in software-center-agent:
assignee: nobody → Michael Nelson (michael.nelson)
importance: Undecided → Low
status: New → In Progress
description: updated
Changed in software-center-agent:
status: In Progress → Fix Committed
Changed in rnr-server:
status: In Progress → Fix Committed
tags: added: sp-1
tags: added: kb-defect
removed: kb-task
Changed in software-center-agent:
assignee: Michael Nelson (michael.nelson) → sticks702@yahoo.com (sticks702)
status: Fix Committed → Fix Released
Changed in rnr-server:
status: Fix Committed → Fix Released
affects: rnr-server → weblive
Changed in software-center-agent:
assignee: sticks702@yahoo.com (sticks702) → Michael Nelson (michael.nelson)
milestone: none → 11.05
affects: weblive → rnr-server
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.