Templates broken after django-web-themes added a light/404.html
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ratings and Reviews server |
Fix Released
|
Low
|
Michael Nelson | ||
Software Center Agent |
Fix Released
|
Low
|
Michael Nelson |
Bug Description
django-web-themes recently got a light/404.html which is found by our django whenever a 404 is raised (as we have /path/to/
The problem is that light/404.html extends light/index.
I chatted with mhall119 about it, and the intended way of using the light web theme is for us to use "/path/
For us to do this requires a tiny patch to light/404.html so that we can include the extra oops info.
Note: When this fix is going to be deployed, we need to
1) update our configs on both projects with the new config schema option for preflight_
2) Update the template_dirs on the configs (removing the 'light/')
3) Update the templates/404.html and /500.html in the rnr configs (in the same way as the django_
Related branches
- Michael Foord (community): Approve
- Ratings and Reviews Developers: Pending requested
-
Diff: 118 lines (+21/-18)9 files modifieddjango_project/config_dev/schema.py (+5/-0)
django_project/templates/light/404.html (+7/-0)
src/reviewsapp/templates/404.html (+3/-12)
src/reviewsapp/templates/500.html (+1/-1)
src/reviewsapp/templates/forbidden.html (+1/-1)
src/reviewsapp/templates/reviewsapp/overview.html (+1/-1)
src/reviewsapp/templates/reviewsapp/reviewmoderation_details.html (+1/-1)
src/reviewsapp/templates/reviewsapp/reviewmoderation_form.html (+1/-1)
src/reviewsapp/templates/reviewsapp/reviewmoderation_list.html (+1/-1)
summary: |
- Tests failing after django-web-themes added a light/404.html + Templates broken after django-web-themes added a light/404.html |
tags: | added: kb-task |
Changed in rnr-server: | |
assignee: | nobody → Michael Nelson (michael.nelson) |
importance: | Undecided → Low |
status: | New → In Progress |
Changed in software-center-agent: | |
assignee: | nobody → Michael Nelson (michael.nelson) |
importance: | Undecided → Low |
status: | New → In Progress |
description: | updated |
Changed in software-center-agent: | |
status: | In Progress → Fix Committed |
Changed in rnr-server: | |
status: | In Progress → Fix Committed |
tags: | added: sp-1 |
tags: |
added: kb-defect removed: kb-task |
Changed in software-center-agent: | |
assignee: | Michael Nelson (michael.nelson) → sticks702@yahoo.com (sticks702) |
status: | Fix Committed → Fix Released |
Changed in rnr-server: | |
status: | Fix Committed → Fix Released |
affects: | rnr-server → weblive |
Changed in software-center-agent: | |
assignee: | sticks702@yahoo.com (sticks702) → Michael Nelson (michael.nelson) |
milestone: | none → 11.05 |
affects: | weblive → rnr-server |