Y.lp.soyuz.base.makeFailureNode and .makeInProgressNode do not escape given text before inserting into DOM
Bug #744204 reported by
Gavin Panella
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Henning Eggers | ||
Bug Description
Specifically they do things like:
message.
Instead they should do:
message.
OTOH, if these functions are meant to accept mark-up I would argue
that that's a design flaw. They should accept a single Y.Node in that
case (or a DOM node I suppose).
Related branches
lp://staging/~henninge/launchpad/devel-744204-escaping-soyuz-base
- Robert Collins (community): Approve
- William Grant: Approve (code*)
-
Diff: 156 lines (+21/-31)4 files modifiedlib/lp/registry/javascript/distroseriesdifferences_details.js (+10/-12)
lib/lp/soyuz/javascript/base.js (+9/-17)
lib/lp/soyuz/templates/archive-macros.pt (+1/-1)
lib/lp/soyuz/templates/archive-packages.pt (+1/-1)
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Henning Eggers (henninge) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| Changed in launchpad: | |
| milestone: | none → 11.05 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| visibility: | private → public |
To post a comment you must log in.
Fixed in stable r12796 <http://