Remove app name completely
Bug #737649 reported by
Anthony Lenton
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ratings and Reviews server |
Fix Released
|
Medium
|
Michael Nelson | ||
Bug Description
Having per application reviews (as opposed to per package) only benefits corner-case packages with more than one application, and bring quite a few complications and pains (no proper way to validate which applications belong to a package, no way to handle when an app within a package is renamed, extra load calculating and transmitting aggregated stats).
So, we'll move to a per-package review model. This change should be backwards compatible, or at least not make the current client fail miserably.
Related branches
lp://staging/~michael.nelson/rnr-server/dont-depend-on-appname
- Anthony Lenton (community): Approve
-
Diff: 583 lines (+417/-20)8 files modifiedsrc/reviewsapp/api/handlers.py (+1/-1)
src/reviewsapp/management/commands/populate.py (+2/-2)
src/reviewsapp/migrations/0006_add_review_app_name.py (+160/-0)
src/reviewsapp/migrations/0007_populate_review_app_name_and_remove_redundant_software_items.py (+234/-0)
src/reviewsapp/models/reviews.py (+6/-4)
src/reviewsapp/tests/factory.py (+3/-2)
src/reviewsapp/tests/test_handlers.py (+8/-8)
src/reviewsapp/tests/test_rnrclient.py (+3/-3)
lp://staging/~michael.nelson/rnr-server/dont-depend-on-appname-2
- Anthony Lenton (community): Approve
-
Diff: 441 lines (+192/-36)10 files modifiedsrc/reviewsapp/api/handlers.py (+6/-2)
src/reviewsapp/forms.py (+1/-2)
src/reviewsapp/management/commands/populate.py (+2/-2)
src/reviewsapp/migrations/0008_remove_softwareitem_app_name.py (+159/-0)
src/reviewsapp/models/reviews.py (+1/-6)
src/reviewsapp/tests/factory.py (+2/-2)
src/reviewsapp/tests/matchers.py (+5/-4)
src/reviewsapp/tests/test_handlers.py (+8/-8)
src/reviewsapp/tests/test_rnrclient.py (+6/-7)
src/reviewsapp/utilities.py (+2/-3)
lp://staging/~michael.nelson/rnr-server/dont-depend-on-appname-3
- Anthony Lenton (community): Approve
-
Diff: 42 lines (+8/-7)2 files modifiedsrc/reviewsapp/api/handlers.py (+1/-3)
src/reviewsapp/tests/test_handlers.py (+7/-4)
| tags: | added: kb-improvement |
| Changed in rnr-server: | |
| importance: | Undecided → Medium |
Revision history for this message
| Michael Nelson (michael.nelson) wrote | #1 |
| Changed in rnr-server: | |
| assignee: | nobody → Michael Nelson (michael.nelson) |
Revision history for this message
| Michael Nelson (michael.nelson) wrote | #2 |
| Changed in rnr-server: | |
| status: | New → Fix Committed |
Revision history for this message
| Michael Nelson (michael.nelson) wrote | #3 |
Revision history for this message
| Michael Nelson (michael.nelson) wrote | #4 |
Revision history for this message
| Michael Nelson (michael.nelson) wrote | #5 |
Revision history for this message
| Michael Nelson (michael.nelson) wrote | #6 |
Revision history for this message
| Michael Nelson (michael.nelson) wrote | #7 |
Revision history for this message
| Michael Nelson (michael.nelson) wrote | #8 |
Revision history for this message
| Michael Nelson (michael.nelson) wrote | #9 |
Revision history for this message
| Dave Morley (davmor2) wrote | #10 |
| Changed in rnr-server: | |
| status: | Fix Committed → Fix Released |
| Changed in rnr-server: | |
| milestone: | none → 11.03 |
To post a comment you must log in.
So depending on discussions with mvo and achuni, we can choose to land the first 2 branches or all three, depending on whether we want to:
1) Just update so that statistics are now for packages only (no app_name in statistics results either), and we verify all package_names in repositories with LP (this is the first two branches),
2) We also update the get_reviews api call to ignore app_names and just return all reviews for the specified package (branch 3).