OS API /limits resource
Bug #728587 reported by
Brian Lamar
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Medium
|
Brian Lamar |
Bug Description
The API specifies the ability to hit /limits in OpenStack API and receive a listing. For a complete example of what this should look like, see http://
Related branches
lp://staging/~blamar/nova/lp728587
- Rick Harris (community): Approve
- Paul Voccio (community): Approve
- Titan: Pending requested
- Mark Washenberger: Pending requested
-
Diff: 1238 lines (+912/-169)8 files modifiedetc/api-paste.ini (+1/-1)
nova/api/openstack/__init__.py (+6/-0)
nova/api/openstack/faults.py (+39/-0)
nova/api/openstack/limits.py (+358/-0)
nova/tests/api/openstack/__init__.py (+1/-1)
nova/tests/api/openstack/fakes.py (+5/-5)
nova/tests/api/openstack/test_adminapi.py (+0/-1)
nova/tests/api/openstack/test_limits.py (+502/-161)
Changed in nova: | |
assignee: | nobody → Brian Lamar (blamar) |
status: | New → In Progress |
Changed in nova: | |
importance: | Undecided → Medium |
Changed in nova: | |
status: | In Progress → Fix Committed |
Changed in nova: | |
milestone: | none → 2011.2 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
To be clear, the reason this diff is so long is because when writing this controller I made so many changes to make everything work this is what amounts to a re-write of Limits in the OpenStack API.
What this gets us that we didn't have before:
1) /limits now returns information about applicable limits correctly serialized into JSON or XML
2) Limits in general have been improved to support:
-Arbitrary regular expressions
-Improved testability (no more `time.sleep` inaccuracies in tests)
-Improved test coverage for limits
3) RateLimitingMid dleware returns correct fault with HTTP 403 and not HTTP 413 correctly serialized to JSON or XML.
4) The first tests in OpenStack API to test XML serialized results. (Surprising!)