Stellarium

Planet trails are buggy in some projection modes

Bug #724868 reported by Bogdan Marinov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Stellarium
Fix Released
Medium
Guillaume Chereau
Stellarium 0.14.0

Bug Description

Planet trails are buggy in some projection modes.

Affected projection modes:
- perspective (phantom fragments of the trails are projected in the wrong places and move independently from the star field)
- Hammer-Aitoff (probably a separate problem - trails are not rendered correctly when their ends are on opposite sides of the projected star field)
- cylinder (same problem as with Hammer-Aitoff)
- Mercator (same problem as with Hammer-Aitoff)
- orthographic (same problem as with perspective projection)

See this thread in the Feedback forum for the user report that prompted this bug report:
https://sourceforge.net/projects/stellarium/forums/forum/278769/topic/4360224

Alexander Wolf (alexwolf)
tags: added: solar-system
Alexander Wolf (alexwolf)
Changed in stellarium:
milestone: 1.0.0 → none
Alexander Wolf (alexwolf)
Changed in stellarium:
assignee: nobody → Guillaume Chereau (guillaume-chereau)
Alexander Wolf (alexwolf)
tags: added: projection
Revision history for this message
Guillaume Chereau (guillaume-chereau) wrote :

I notice that the meteors also have strange trajectories with some projection modes (at least in perspective projection). I haven't checked much into it, but it might be related.

Revision history for this message
Alexander Wolf (alexwolf) wrote :

Seems we have errors in clipping part of projections. I think this issue - https://bugs.launchpad.net/stellarium/+bug/1450211 - related too.

Revision history for this message
Guillaume Chereau (guillaume-chereau) wrote :

The bug of the perspective projection is due to a clipping problem. I can fix it with this small patch, but I am not sure this won't introduce some other bugs, so I haven't committed yet.

Revision history for this message
Alexander Wolf (alexwolf) wrote :

Apparently this patch fixes bug #1450211 also. Plus I can't see problems with planet trails and meteors with him. And I don't see visible problem with projection.

Changed in stellarium:
milestone: none → 0.14.0
status: Confirmed → In Progress
Revision history for this message
Guillaume Chereau (guillaume-chereau) wrote :

OK, if you think that is acceptable, then I can commit it, and we can still revert if we find some bugs later.

Revision history for this message
Alexander Wolf (alexwolf) wrote :

Yes, it's OK for me.

Revision history for this message
Alexander Wolf (alexwolf) wrote :

Guillaume, what about other projections?

Revision history for this message
Guillaume Chereau (guillaume-chereau) wrote :

I am not really sure about the other projections. The planet trails rendering is a bit strange on my machine: if I select a planet the trail disappears, and I cannot bring it back, even with shift-T. Do we have some screenshots that show the problem?

Revision history for this message
Alexander Wolf (alexwolf) wrote :

Please try set viewing/flag_isolated_trails = false to get old behaviour for trails

Revision history for this message
Guillaume Chereau (guillaume-chereau) wrote :

OK I can see it now. We need to check for segments intersecting the viewport discontinuity like StelPainter::drawSmallCircleArc does. I think we should add a more generic method of StelPainter to draw a line from a list of points. I am going to have a look at it.

Revision history for this message
Guillaume Chereau (guillaume-chereau) wrote :

I just pushed a change that should fix the problem: r7647.

Alexander Wolf (alexwolf)
Changed in stellarium:
status: In Progress → Fix Committed
Alexander Wolf (alexwolf)
Changed in stellarium:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.