changing label of files with same name changes both labels

Bug #724302 reported by Effin Goose
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenShot Video Editor
Fix Released
Medium
Andy Finch

Bug Description

If you have attach two files with the same name, but different paths, and change the label in one, apon reopening the project, both files have the same label. To reproduce:

1) Add test1/image01.jpg to project
2) Add test2/image01.jpg to project

Change label of first image01.jpg. After saving project, and closing openshot and reopening project, both files have same label. This occurs in version 1.3.0, and latest from trunk. Running archlinux (latest, rolling release).

This occurs because the UpdateFileLabel function works on the "name" of the file object. Changing this to use the file objects unique_id fixes this problem. I've attached a bzr send -o of the changes i did to fix this problem. I've also removed references to UpdateFileLabel from the TreeHistory, TreeBlender, and TreeEffects classes, as the cell_edited function is never called in these classes as none of the forms cells are editable.

I've never used bzr before, so not sure if the bzr send -o command is the right one to use in this circumstance, but its output is text based so you can get the patches from the merge file at any rate.

Tags: patch
Revision history for this message
Effin Goose (effingoose) wrote :
description: updated
Revision history for this message
Olivier Girard (eolinwen) wrote :

Thanks a lot.

Changed in openshot:
milestone: none → 1.4.0
moimael (moimael)
Changed in openshot:
status: New → Confirmed
importance: Undecided → Medium
tags: added: patch
Andy Finch (fincha)
Changed in openshot:
assignee: nobody → Andy Finch (fincha)
status: Confirmed → In Progress
Andy Finch (fincha)
Changed in openshot:
status: In Progress → Fix Committed
Andy Finch (fincha)
Changed in openshot:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.