ICQ, AIM and MSN fields missing in shoutcast properties

Hmm, yea I had heard about this from someone on IRC. They were applying their own patch to Shoutcast to do this. I think we could easily take that patch and use it -- the downside being that we have to build and include shoutcast ourselves on Ubuntu.

And what's wrong with submitting that patch upstream? Have those fields default to null values if not specified.

To be precise, the patch will relate to libshout2. As fas as I can tell you, the patch is rather simple.

Just add the following functions to the implementation in shout.c and shout.h:

int shout_set_aim(shout_t *self, const char *url);
int shout_set_icq(shout_t *self, const char *url);

Furthermore, extend the struct 'shout' in shout_private.h to include the fields for aim, icq and so on.
Finally, replace line 1291 in shout.c.

That's all I think. Note that messenger fields are only applicable for shoutcast, i.e., the ICY protocol.

Unfortunately, RJ has right. We'll need to maintain our own repository. The icecast project does not seem to be very active. The latest version of libshout2 is around 5 to 6 years old.

I just heard from another user who was requesting this feature.

Note that there's also a bug in libshout 2.2.2 (latest) in the code that sends the current blank icy-aim (etc) lines:

shout.c:
  if (queue_str(self, "icy-irc:\nicy-aim:\nicy-icq:\n"))
   break;

http://svn.xiph.org/icecast/trunk/libshout/src/shout.c
Those are supposed to be separated by \r\n, not just \n. If they had called queue_str() three times separately, I think those line endings would be added by queue_str(). This is something that will get fixed when we implement this properly.

Ref:
http://forums.winamp.com/archive/index.php/t-278436.html

You are so right Albert. That's why I think it's an easy fix. But do we really want to maintain our own customized libshout? Maybe static linking would make sense, so Mixxx does not require other dependencies if someone wants to compile Mixxx. What do you think?

Just to clarify, Icecast does support multiple users, you can create as many authenticated mount points as you need. See the documentation here:

http://www.icecast.org/docs/icecast-2.3.2/icecast2_config_file.html#mount

Icecast is a very active project, see https://github.com/karlheyes/icecast-kh where the last commit was three days ago.

ph3-der-loewe is working on adding this metadata support to libshout

Tobias and anyone else listening to this bug. Can we get testers who are willing to try out a new version of libshout? I don't have any software that uses this metadata (irc/aim/msn/etc). Once libshout has this then adding it to Mixxx will be easy.

There are several years past, how far is this project?

i need this, RAFFI TEA already clarified the reasons for that in his comments to this bug, so i have to use the icq-field to submit my username for the station.

Is there a working fix for Mixxx2.1?

It looks like this is done since 2015-11-20 and v2.4.0

https://github.com/xiph/Icecast-libshout/commit/56607922420e1cd2fd09309f53f2833844f0ee4c

Which is part of the new Ubuntu LTS landed today:
https://packages.ubuntu.com/bionic/libshout3

So it is time to finally fix this Bug!

You are wrong.
Mixxx doesnt have 2.4.0.
Its on 2.1.x.
Its not a question of OS, its a question of implementation for irc, icq and aim fields in config for mixxx.

Yes right. I meant it is done in libshout, so we are able to fix this bug in Mixxx.
Do you have interest to adopt this?

Just submitted pull request for it - https://github.com/mixxxdj/mixxx/pull/1731

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5789