Odoo Addons (MOVED TO GITHUB)

[6.0] Invoicing values from wizard are lost when creating purchase invoice from receptions

Bug #724198 reported by Sebastán Jara on 2011-02-24

This bug affects 3 people

Affects		Status	Importance	Assigned to	Milestone
	Odoo Addons (MOVED TO GITHUB)	Fix Released	Low	OpenERP Publisher's Warranty Team	Odoo Addons (MOVED TO GITHUB) 6.0.2

Bug Description

At 6.0.1 OpenERP version, when you try to create a purchase invoice from reception, next values that appears at invoicing wizard are not apply: Destination Journal, Group by partner, Invoice date.

The steps to reproduce the bug are next:
1) Create a purchase order, indicating "From Picking" at Invoicing Control.
2) Click on "Convert to Purchase Order" button.
3) To generate the receptions documents, click on "Receptions" at right list options.
4) Click on "Process" button to confirm the stock reception, and validate the quantities.
5) Click on "Create invoice" to generate the purchase invoice. A wizard appears asking for Destination Journal, Group by partner, Invoice date. Complete this fields and click on "Create" button.
6) A tree view of new draft purchase invoice created appears. Click on this invoice to access form view. You can verify that the invoice hasn't filled the Journal and Invoice Date fields.
7) Also, if you have more than one reception document from same partner, and try to invoicing some of then at same time (click on "Action" top button from Receptions tree view), and select Group by partner option, OpenERP generates one different invoice from every reception document.

See original description

Tags:

Related branches

lp://staging/~openerp-dev/openobject-addons/6.0-bug-724198-jma

Merged into lp://staging/openobject-addons/6.0 at revision 4477

Anup(SerpentCS) (community): Approve on 2011-03-23

Jay Vora (Serpent Consulting Services) (community): Approve on 2011-03-10

OpenERP buildbot (community): Approve on 2011-03-10

Revision history for this message

Sebastán Jara (sebas-jara-bravo) wrote on 2011-02-24:

OpenERPBug.jpg Edit (87.9 KiB, image/jpeg)

Sebastán Jara (sebas-jara-bravo) on 2011-02-24

description:	updated
summary:	- invoicing values from wizard are lost when creating purchase invoice - from receptions + [6.0] Invoicing values from wizard are lost when creating purchase + invoice from receptions

Revision history for this message

Amit Parik (amit-parik) wrote on 2011-02-24:

Hello,

I am confirming this issue for stable 6.0 only and it is already fixed in current trunk code.

Thanks

tags:	added: 6.0
Changed in openobject-addons:
assignee:	nobody → Jay Vora (OpenERP) (jvo-openerp)
importance:	Undecided → Low
status:	New → Confirmed

Revision history for this message

Sebastán Jara (sebas-jara-bravo) wrote on 2011-03-03:

Hello.

Also, I just discovered the problem: the parameters passed to call "action_invoice_create" function are not captured. I copy below the affected code (approximately at line 127 in "stock_invoice_onshipping.py" file)

        res = picking_pool.action_invoice_create(cr, uid, active_ids,
              journal_id = onshipdata_obj[0]['journal_id'],
              group = onshipdata_obj[0]['group'],
              type = inv_type,
              context=context)

It's the same problem that occurs at Bug https://bugs.launchpad.net/openobject-addons/+bug/724253.

Thanks.

Revision history for this message

Sebastán Jara (sebas-jara-bravo) wrote on 2011-03-03:

Hello again

I try to show my depuration process. I've attached below 3 images:

1) "create_invoice" method from "wizard/stock_invoice_onshipping.py". As you can see, I added print commands.
2) "action_invoice_create" method from "stock.py". As you can see, I also added print commands.
3) The exit result

You can verify that parameters values are not passed correctly from "create_invoice" method from "wizard/stock_invoice_onshipping.py" to "action_invoice_create" method from "stock.py".

Sorry for my insistence.

Thanks.

Revision history for this message

Sebastán Jara (sebas-jara-bravo) wrote on 2011-03-03:

Image1.jpg Edit (85.2 KiB, image/jpeg)

Revision history for this message

Sebastán Jara (sebas-jara-bravo) wrote on 2011-03-03:

Image2.jpg Edit (53.1 KiB, image/jpeg)

Revision history for this message

Sebastán Jara (sebas-jara-bravo) wrote on 2011-03-03:

Image3.jpg Edit (80.9 KiB, image/jpeg)

Revision history for this message

JMA(Open ERP) (jma-openerp) wrote on 2011-03-10:

Hello Sebas KM Sistemas,

There are few changes upfront.

A Supplier Invoice always has journal with type: 'purchase'.
So on the wizard, even if you select the Sales journal which has type:'sale' that value will not be preserved on the Supplier Invoice because of the filter therein.
However to simplify things we have filtered the journals in the selection box itself.

Thank you for your co-operation.

@Amit: Please be sure before you comment.
I could not see this been fixed anywhere.
We have tested and it surely appears as a bug on trunk as well.
This is misleading for the users.

This has been fixed by revision:
4458 : <email address hidden>

Please update your code to get the latest changes.

Regards,
JMA(OpenERP)

Changed in openobject-addons:
status:	Confirmed → Fix Committed

Anup(SerpentCS) (anup-serpent) on 2011-03-23

Changed in openobject-addons:
status:	Fix Committed → Fix Released
assignee:	Jay Vora (OpenERP) (jvo-openerp) → OpenERP Publisher's Warranty Team (openerp-opw)
milestone:	none → 6.0.2