fake_rabbit shouldn't use prefix matching on routing keys
Bug #723447 reported by
justinsb
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Low
|
justinsb |
Bug Description
fake_rabbit is currently parsing the routing_keys, as if we were doing prefix matching. I had a bug with a message being received multiple times because of this (I'm working on some complicated unit tests) We're just using straight routing_key literal matching, so fake_rabbit shouldn't be doing this.
Related branches
lp://staging/~justin-fathomdb/nova/no-prefix-in-fakerabbit
- Jay Pipes (community): Approve
- termie (community): Approve
- Soren Hansen (community): Needs Information
- Vish Ishaya (community): Approve
-
Diff: 23 lines (+1/-1)2 files modifiednova/fakerabbit.py (+0/-1)
nova/network/api.py (+1/-0)
Changed in nova: | |
assignee: | nobody → justinsb (justin-fathomdb) |
importance: | Undecided → Low |
status: | New → In Progress |
Changed in nova: | |
status: | In Progress → Fix Committed |
Changed in nova: | |
milestone: | none → 2011.2 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This fix then broke test_associate_ disassociate_ address. There's another bug there - it was building a queue name of "network.None", because queue_get_for in sqlalchemy/api.py was blindly appending the 'None' to the queue name. Updated fix on its way!