when switched to read-only and with the master disabled, we're still querying the master DB in staging
Bug #716494 reported by
Tom Haddon
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical SSO provider |
Fix Released
|
High
|
Ricardo Kirkner | ||
Bug Description
During testing of the SSO staging schema upgrade today we discovered that when we switch both the ubuntu branded and launchpad branded staging SSO appservers to read-only mode and with the master DB disabled, we were still sending queries to the master DB, and none to the slave DB.
It's possible this has also been affecting us in production but we've never been aware of it before because we've never done DB upgrades that take out locks before, so we wouldn't have noticed.
Related branches
lp://staging/~canonical-isd-hackers/canonical-identity-provider/716494-readonly-set-db
- David Owen (community): Approve
-
Diff: 86 lines (+36/-6)2 files modifiedidentityprovider/readonly.py (+6/-2)
identityprovider/tests/test_readonly.py (+30/-4)
| tags: | added: canonical-losa-isd |
| Changed in canonical-identity-provider: | |
| importance: | Undecided → High |
Revision history for this message
| Tom Haddon (mthaddon) wrote | #1 |
Revision history for this message
| Ricardo Kirkner (ricardokirkner) wrote | #2 |
| Changed in canonical-identity-provider: | |
| status: | New → Fix Committed |
| assignee: | nobody → Ricardo Kirkner (ricardokirkner) |
| Changed in canonical-identity-provider: | |
| milestone: | none → 11.02 |
Revision history for this message
| Dave Morley (davmor2) wrote | #3 |
| Changed in canonical-identity-provider: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
We took the master DB down, and every page OOPSed. Had though this might switch things over for us, but it wasn't the case.