PPL

Changing the settings page should generate a log entry

Bug #715888 reported by Christopher Adams on 2011-02-09

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	PPL	In Progress	Medium	Brad Phillips	PPL 0.35 "refactor and optimize"

Bug Description

Making changes to the settings page should generate a log entry.

Minimal log:
You changed your settings.

Better log:
  You updated your email address.
  You set a new password.
  You changed your name.

Best log:
  You changed your email address to XYZ
  You set a new password.
  You changed your name to XYZ.

To implement: Look at how the form for editing a story saves a new log record. Copy that and implement the minimal log of "You changed your settings."

Later you can revisit the ideas for a Better or Best log if time permits.

Christopher Adams (christopheradams) on 2011-02-09

Changed in ppl:
status:	New → Confirmed
importance:	Undecided → Medium
assignee:	nobody → Brad Phillips (brad-bradphillips)
milestone:	none → 0.3

Revision history for this message

Christopher Adams (christopheradams) wrote on 2011-02-24:

So...

I adapted the following autofields from the story edit form:

owner_id->ppl_logs|SystemGOD:owner id:value:[userid]

log_type->ppl_logs|SystemGOD:log type:value:1

created_at->ppl_logs|SystemGOD:created at:datetime

message->ppl_logs|SystemGOD:message:value: You updated your settings.

But they don't work! WHY?

Notice: Undefined index: owner_id->ppl_logs in /home/aikilab/public_html/pple/system/libraries/records.php on line 907

Notice: Undefined index: log_type->ppl_logs in /home/aikilab/public_html/pple/system/libraries/records.php on line 907

Notice: Undefined index: created_at->ppl_logs in /home/aikilab/public_html/pple/system/libraries/records.php on line 907

Notice: Undefined index: message->ppl_logs in /home/aikilab/public_html/pple/system/libraries/records.php on line 907

Notice: Undefined variable: this_pkey in /home/aikilab/public_html/pple/system/libraries/records.php on line 991

Revision history for this message

Bassel Safadi (bassel) wrote on 2011-02-24: Re: [Bug 715888] Re: Changing the settings page should generate a log entry

checking it...

On Thu, Feb 24, 2011 at 11:30 AM, Christopher Adams <email address hidden>wrote:

> So...
>
> I adapted the following autofields from the story edit form:
>
> owner_id->ppl_logs|SystemGOD:owner id:value:[userid]
>
> log_type->ppl_logs|SystemGOD:log type:value:1
>
> created_at->ppl_logs|SystemGOD:created at:datetime
>
> message->ppl_logs|SystemGOD:message:value: You updated your settings.
>
> But they don't work! WHY?
>
> Notice: Undefined index: owner_id->ppl_logs in
> /home/aikilab/public_html/pple/system/libraries/records.php on line 907
>
> Notice: Undefined index: log_type->ppl_logs in
> /home/aikilab/public_html/pple/system/libraries/records.php on line 907
>
> Notice: Undefined index: created_at->ppl_logs in
> /home/aikilab/public_html/pple/system/libraries/records.php on line 907
>
> Notice: Undefined index: message->ppl_logs in
> /home/aikilab/public_html/pple/system/libraries/records.php on line 907
>
> Notice: Undefined variable: this_pkey in
> /home/aikilab/public_html/pple/system/libraries/records.php on line 991
>
> Notice: Undefined variable: this_pkey in
> /home/aikilab/public_html/pple/system/libraries/records.php on line 991
>
> Notice: Undefined variable: this_pkey in
> /home/aikilab/public_html/pple/system/libraries/records.php on line 991
>
> Notice: Undefined variable: this_pkey in
> /home/aikilab/public_html/pple/system/libraries/records.php on line 991
>
> --
> You received this bug notification because you are a member of PPL
> Developers, which is subscribed to PPL.
> https://bugs.launchpad.net/bugs/715888
>
> Title:
> Changing the settings page should generate a log entry
>
> Status in PPL:
> Confirmed
>
> Bug description:
> Making changes to the settings page should generate a log entry.
>
> Minimal log:
> You changed your settings.
>
> Better log:
> You updated your email address.
> You set a new password.
> You changed your name.
>
> Best log:
> You changed your email address to XYZ
> You set a new password.
> You changed your name to XYZ.
>
> To implement: Look at how the form for editing a story saves a new log
> record. Copy that and implement the minimal log of "You changed your
> settings."
>
> Later you can revisit the ideas for a Better or Best log if time
> permits.
>

--
Bassel Safadi
http://bassel.ws
http://aikilab.org
Global +1 323-545-3855
Singapore +65 93488349

checking it...

On Thu, Feb 24, 2011 at 11:30 AM, Christopher Adams <chris@raysend.com>wrote:

> So...
>
> I adapted the following autofields from the story edit form:
>
>  owner_id->ppl_logs|SystemGOD:owner id:value:[userid]
>
>  log_type->ppl_logs|SystemGOD:log type:value:1
>
>  created_at->ppl_logs|SystemGOD:created at:datetime
>
>  message->ppl_logs|SystemGOD:message:value: You updated your settings.
>
> But they don't work! WHY?
>
> Notice: Undefined index: owner_id->ppl_logs in
> /home/aikilab/public_html/pple/system/libraries/records.php on line 907
>
> Notice: Undefined index: log_type->ppl_logs in
> /home/aikilab/public_html/pple/system/libraries/records.php on line 907
>
> Notice: Undefined index: created_at->ppl_logs in
> /home/aikilab/public_html/pple/system/libraries/records.php on line 907
>
> Notice: Undefined index: message->ppl_logs in
> /home/aikilab/public_html/pple/system/libraries/records.php on line 907
>
> Notice: Undefined variable: this_pkey in
> /home/aikilab/public_html/pple/system/libraries/records.php on line 991
>
> Notice: Undefined variable: this_pkey in
> /home/aikilab/public_html/pple/system/libraries/records.php on line 991
>
> Notice: Undefined variable: this_pkey in
> /home/aikilab/public_html/pple/system/libraries/records.php on line 991
>
> Notice: Undefined variable: this_pkey in
> /home/aikilab/public_html/pple/system/libraries/records.php on line 991
>
> --
> You received this bug notification because you are a member of PPL
> Developers, which is subscribed to PPL.
> https://bugs.launchpad.net/bugs/715888
>
> Title:
>  Changing the settings page should generate a log entry
>
> Status in PPL:
>  Confirmed
>
> Bug description:
>  Making changes to the settings page should generate a log entry.
>
>  Minimal log:
>    You changed your settings.
>
>  Better log:
>    You updated your email address.
>    You set a new password.
>    You changed your name.
>
>  Best log:
>    You changed your email address to XYZ
>    You set a new password.
>    You changed your name to XYZ.
>
>  To implement: Look at how the form for editing a story saves a new log
>  record. Copy that and implement the minimal log of "You changed your
>  settings."
>
>  Later you can revisit the ideas for a Better or Best log if time
>  permits.
>

-- 
Bassel Safadi
http://bassel.ws
http://aikilab.org
Global +1 323-545-3855
Singapore +65 93488349

Revision history for this message

Brad Phillips (brad-bradphillips) wrote on 2011-02-28:

Ok, I was able to get this to successfully submit a log & all of the fields are correctly filled in. For some reason, however, when the form is submitted I get the following errors, even though the form reports being successfully submitted & the log is generated & displays on the /dashboard as it should.

Notice: Trying to get property of non-object in /home/aikilab/public_html/pple/system/libraries/records.php on line 994

Notice: Trying to get property of non-object in /home/aikilab/public_html/pple/system/libraries/records.php on line 998

So, it's working except for 2 random errors?

Changed in ppl:
status:	Confirmed → In Progress

rejon (rejon) on 2011-03-02

Changed in ppl:
status:	In Progress → Fix Released

Revision history for this message

rejon (rejon) wrote on 2011-03-02:

brad, just get this closed out and can close 0.3 release of ppl. great work!

Changed in ppl:
status:	Fix Released → In Progress

Christopher Adams (christopheradams) on 2011-03-02

Changed in ppl:
milestone:	0.3 → 0.35

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.