OpenStack Compute (nova)

Missing items in release tarball

Bug #714678 reported by Thierry Carrez
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Thierry Carrez
OpenStack Compute (nova) 2011.2 "cactus"
Bexar
Fix Released
Critical
Thierry Carrez
OpenStack Compute (nova) 2011.1.1 "bexar"

Bug Description

Some files and directories are missing in the tarballs:

bin/nova-ajax-console-proxy
bin/nova-combined
bin/nova-console
bin/nova-direct-api
bin/stack
bzrplugins/novalog/__init__.py
contrib/boto_v6/ec2/connection.py
contrib/boto_v6/ec2/instance.py
contrib/boto_v6/__init__.py
contrib/nova.sh
contrib/puppet/files/etc/default/nova-compute
contrib/puppet/files/etc/default/nova-volume
contrib/puppet/files/etc/issue
contrib/puppet/files/etc/libvirt/qemu.conf
contrib/puppet/files/etc/lvm/lvm.conf
contrib/puppet/files/etc/nova.conf
contrib/puppet/files/production/boto.cfg
contrib/puppet/files/production/genvpn.sh
contrib/puppet/files/production/libvirt.qemu.xml.template
contrib/puppet/files/production/my.cnf
contrib/puppet/files/production/nova-iptables
contrib/puppet/files/production/nova-iscsi-dev.sh
contrib/puppet/files/production/setup_data.sh
contrib/puppet/files/production/slap.sh
contrib/puppet/fileserver.conf
contrib/puppet/manifests/classes/apt.pp
contrib/puppet/manifests/classes/issue.pp
contrib/puppet/manifests/classes/kern_module.pp
contrib/puppet/manifests/classes/loopback.pp
contrib/puppet/manifests/classes/lvmconf.pp
contrib/puppet/manifests/classes/lvm.pp
contrib/puppet/manifests/classes/nova.pp
contrib/puppet/manifests/classes/swift.pp
contrib/puppet/manifests/site.pp
contrib/puppet/manifests/templates.pp
contrib/puppet/puppet.conf
contrib/puppet/templates/haproxy.cfg.erb
contrib/puppet/templates/monitrc-nova-api.erb
contrib/puppet/templates/nova-iptables.erb
contrib/puppet/templates/production/nova-common.conf.erb
contrib/puppet/templates/production/nova-nova.conf.erb
locale/nova.pot
nova/auth/nova_openldap.schema
nova/auth/nova_sun.schema
nova/auth/opendj.sh
nova/auth/openssh-lpk_openldap.schema
nova/auth/openssh-lpk_sun.schema
nova/cloudpipe/bootscript.template
nova/console/xvp.conf.template
nova/db/sqlalchemy/migrate_repo/README
plugins/xenserver/doc/networking.rst
plugins/xenserver/networking/etc/init.d/host-rules
plugins/xenserver/networking/etc/xensource/scripts/vif_5.6-fp1.patch
plugins/xenserver/networking/etc/xensource/scripts/vif_rules.py
plugins/xenserver/xenapi/etc/xapi.d/plugins/agent
plugins/xenserver/xenapi/etc/xapi.d/plugins/glance
plugins/xenserver/xenapi/etc/xapi.d/plugins/objectstore
plugins/xenserver/xenapi/etc/xapi.d/plugins/pluginlib_nova.py
plugins/xenserver/xenapi/etc/xapi.d/plugins/xenstore.py
plugins/xenserver/xenapi/README

See original description

Related branches

lp://staging/~ttx/nova/lp714678
Devin Carlen (community): Approve
Jay Pipes (community): Approve
Diff: 61 lines (+16/-1)
2 files modified
MANIFEST.in (+10/-0)
setup.py (+6/-1)
Revision history for this message
Thierry Carrez (ttx) wrote :

Soren ISTR you hacked a new Hudson job to track the diff between branch and tarball, could we use it to check ?

Thierry Carrez (ttx)
summary: - Missing directories in Bexar release tarball
+ Missing items in Bexar release tarball
Thierry Carrez (ttx)
description: updated
Revision history for this message
Thierry Carrez (ttx) wrote : Re: Missing items in Bexar release tarball

Checked that all items are now in the tarball produced by "python setup.py sdist".

Changed in nova:
assignee: nobody → Thierry Carrez (ttx)
importance: Undecided → Critical
status: New → In Progress
Revision history for this message
Thierry Carrez (ttx) wrote :

The linked branch still uses 2011.1 as the version. Depending on whether we release the resulting tarball as nova-2011.1-full.tar.gz or as nova-2011.1.1.tar.gz (will be discussed at the weekly meeting today), we might need to push a version change as well.

Revision history for this message
Thierry Carrez (ttx) wrote :

<jaypipes> ttx: translations aren't in there as binary files.
<jaypipes> ttx: still working on that...please don't merge it into bexar trunk yet :)

Thierry Carrez (ttx)
summary: - Missing items in Bexar release tarball
+ Missing items in release tarball
tags: removed: bexar-post-release
Thierry Carrez (ttx)
Changed in nova:
importance: Critical → High
OpenStack Infra (hudson-openstack)
Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
Thierry Carrez (ttx) wrote :

validating fix with build bzr651:

--- /tmp/branch_contents
+++ /tmp/tarball_contents
-./.bzr
-./.bzr/branch
-./.bzr/branch/branch.conf
-./.bzr/branch-format
-./.bzr/branch/format
-./.bzr/branch/last-revision
-./.bzr/branch-lock
-./.bzr/branch/lock
-./.bzr/branch/tags
-./.bzr/checkout
-./.bzr/checkout/conflicts
-./.bzr/checkout/dirstate
-./.bzr/checkout/format
-./.bzr/checkout/lock
-./.bzr/checkout/views
-./.bzrignore
-./.bzr/README
+./bzrplugins/novalog/__init__.pyc
+./ChangeLog
-./doc/source/api
-./.gitignore
-./.mailmap
+./nova.egg-info
+./nova.egg-info/dependency_links.txt
+./nova.egg-info/PKG-INFO
+./nova.egg-info/SOURCES.txt
+./nova.egg-info/top_level.txt
+./nova/vcsversion.py
+./PKG-INFO
+./smoketests/__init__.pyc

The only things that don't look like valid build artifacts to me are:
+./bzrplugins/novalog/__init__.pyc
-./doc/source/api
+./smoketests/__init__.pyc

bzrplugins/novalog/__init__.pyc gets generated by setup.py execution. smoketests/__init__.pyc apparently gets generated by find_packages(exclude=['bin', 'smoketests'])... I think we should add a global-exclude *.pyc to MANIFEST.in to get rid of them.

doc/source/api is an empty directory, I think it's safe for the tarball not to ship it.

Revision history for this message
Thierry Carrez (ttx) wrote :

validating fix against candidate build bzr653:

--- /tmp/branch_contents 2011-02-25 11:06:11.512406424 +0100
+++ /tmp/tarball_contents 2011-02-25 11:07:07.815363668 +0100
-./.bzr
-./.bzr/branch
-./.bzr/branch/branch.conf
-./.bzr/branch-format
-./.bzr/branch/format
-./.bzr/branch/last-revision
-./.bzr/branch-lock
-./.bzr/branch/lock
-./.bzr/branch/tags
-./.bzr/checkout
-./.bzr/checkout/conflicts
-./.bzr/checkout/dirstate
-./.bzr/checkout/format
-./.bzr/checkout/lock
-./.bzr/checkout/views
-./.bzrignore
-./.bzr/README
+./ChangeLog
-./doc/source/api
-./.gitignore
-./.mailmap
+./nova.egg-info
+./nova.egg-info/dependency_links.txt
+./nova.egg-info/PKG-INFO
+./nova.egg-info/SOURCES.txt
+./nova.egg-info/top_level.txt
+./nova/vcsversion.py
+./PKG-INFO

I think that is correct.

Thierry Carrez (ttx)
Changed in nova:
milestone: none → 2011.2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.