New localized strings with >1 placeholder still being added to trunk not using dict formating
Bug #708309 reported by
Ed Leafe
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Compute (nova) |
Fix Released
|
Low
|
Ed Leafe | ||
Bug Description
Since bug 703041 was fixed and merged into trunk, at least 3 new cases where localized strings have been added that incorrectly use positional formatting instead of dict/mapping formatting. There is nothing to prevent even more from being added in the future.
To fix this, a unit test needs to be added that detects such strings and reports them so that they can be corrected. Any incorrect strings currently in trunk should also be fixed.
Related branches
lp://staging/~ed-leafe/nova/lp708309
- Jay Pipes (community): Approve
- Vish Ishaya (community): Approve
-
Diff: 148 lines (+106/-5)4 files modifiednova/service.py (+3/-2)
nova/tests/test_localization.py (+100/-0)
nova/utils.py (+2/-2)
nova/virt/xenapi/vm_utils.py (+1/-1)
| Changed in nova: | |
| assignee: | nobody → Ed Leafe (ed-leafe) |
Revision history for this message
| Thierry Carrez (ttx) wrote | #1 |
| Changed in nova: | |
| importance: | Undecided → Low |
| status: | New → Triaged |
| Changed in nova: | |
| status: | Triaged → Fix Committed |
| Changed in nova: | |
| milestone: | none → 2011.1 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Maybe we should have a "logging/i18n" reference wikipage detailing the proper way to do it (linked from CodingStandards) so that we can point people to it when they fail.