VLAN field in networks table should be constrained
Bug #708025 reported by
Salvatore Orlando
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Low
|
Ricardo Carrillo Cruz |
Bug Description
nova-manage currently allows to create networks with an arbitrary integer for the VLAN ID.
For instance, the following comands result in a record successfully added to the networks table:
nova-manage network create 10.0.4.0/24 1 256 -25
nova-manage network create 10.0.4.0/24 1 256 5500
However, vconfig will fail when trying to create the vlan interface with the following error:
ERROR: trying to add VLAN #XXXX to IF -:eth0:- error: Numerical result out of range
the create_networks method of the VlanManager class should probably return an error code if vlan_start + num_networks > 4094
Related branches
lp://staging/~rcarrillocruz/nova/lp708025
- Soren Hansen (community): Approve
- Rick Harris (community): Approve
- Thierry Carrez (community): Approve
- Jay Pipes (community): Approve
-
Diff: 16 lines (+6/-0)1 file modifiednova/network/manager.py (+6/-0)
Changed in nova: | |
importance: | Undecided → Low |
status: | New → Confirmed |
Changed in nova: | |
assignee: | nobody → Ricardo Carrillo Cruz (rcc) |
status: | Confirmed → In Progress |
Changed in nova: | |
status: | In Progress → Fix Committed |
Changed in nova: | |
milestone: | none → 2011.2 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.