Default save file name is always the first in list
Bug #706284 reported by
fuchur
This bug affects 4 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Wishlist
|
Unassigned |
Bug Description
When saving a game the proposed filename is always the name of the first game in the list of saved games. It would be nice if this can be changed to be the name of the current game. If the current game is not a loaded one but a new one the filename field should be left blank. So it won't be possible to overwrite a different saved game by simply clicking Ok.
Related branches
lp://staging/~widelands-dev/widelands/save_dialog_improvements
- cghislai (community): Approve
- SirVer: Needs Fixing
-
Diff: 482 lines (+135/-38)11 files modifiedsrc/game_io/game_preload_data_packet.cc (+20/-7)
src/logic/game.cc (+12/-6)
src/logic/game.h (+2/-2)
src/save_handler.cc (+5/-5)
src/save_handler.h (+11/-8)
src/ui_fsmenu/loadgame.cc (+17/-2)
src/ui_fsmenu/loadgame.h (+3/-0)
src/ui_fsmenu/loadreplay.cc (+26/-2)
src/ui_fsmenu/loadreplay.h (+3/-0)
src/wui/game_main_menu_save_game.cc (+33/-5)
src/wui/game_main_menu_save_game.h (+3/-1)
Changed in widelands: | |
importance: | Undecided → Wishlist |
Changed in widelands: | |
status: | Confirmed → Fix Committed |
milestone: | none → build18-rc1 |
To post a comment you must log in.
Hello fuchur and welcome to Launchpad! :)
You're right. For some reason the first filename is chosen when attempting to save a game (tried with Widelands bzr r5804). Your suggestion sounds reasonable, though I'm unsure if games actually remember if the have been loaded from an earlier save or not.
Another alternative could be to default to the name of the map currently played, or as you suggested, leave it blank. The latter might be the best option though, hopefully sometime in the future combined with the result of bug 565406.