Some strings are not translated in UI or not translatable

Bug #703559 reported by kakurasan
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenShot Video Editor
Fix Released
Low
Unassigned

Bug Description

Some strings("Added clip" etc.) are translatable, but not translated in UI.
Some strings("Added transition" etc.) are not translatable.

Here is a patch for MainGTK.py, but it seems that there are more untranslated("not translated in UI" or "not translatable") strings in AddToTimeline.py, sequences.py, etc.

Revision history for this message
kakurasan (kakurasan) wrote :
Revision history for this message
Andy Finch (fincha) wrote :

The untranslatable strings are all related to actions that appear in the history list.

Changed in openshot:
status: New → Confirmed
Revision history for this message
Olivier Girard (eolinwen) wrote :

Thanks a lot. After checking, it will be in the next version.

Changed in openshot:
milestone: none → 1.3.0
status: Confirmed → Fix Released
Andy Finch (fincha)
Changed in openshot:
status: Fix Released → Confirmed
moimael (moimael)
Changed in openshot:
importance: Undecided → Low
Revision history for this message
IRIE Shinsuke (irie) wrote :

MainGTK_gettext.diff seems insufficient. I made an additional patch.

Revision history for this message
Joop Mevissen (jm) wrote :

I found some more untranslated strings. The first one seems to be a regression: the no files message in the Project files tab ("Choose a Video or Audio File to Begin") isn't translated any more.

The second one is in the message screen what you get when you import some images ("Would you like to import abcd1.jpg as an image sequence?") isn't translated.

And here are all the untranslated strings in the history tab that I could find:

Added clip
Removed clip
Duplicated clip
Sliced clip

Added marker

Added track
Removed track
Moved track up
Moved track down
Renamed track

Added transition
Removed transition
Duplicated transition
Moved transition

Changed clip layout
Changed clip rotation
Changed clip animation

Maybe there are more, but these I found so far :)

I'm using OpenShot 1.3.0, latest trunk (459), Dutch language

Revision history for this message
IRIE Shinsuke (irie) wrote :

Oh... I forgot to include some more modifications. I added one more additional patch.

Revision history for this message
IRIE Shinsuke (irie) wrote :

Probably some of these changes fix not only UI but also actual behaviors, because there are strings compared like:

if folder == _("Remove from Folder"):
 self.project.project_folder.RemoveParent(filename, folder)
else:
 self.project.project_folder.AddParentToFile(filename, folder)

So, I think this issue should be given higher importance.

Revision history for this message
Jonathan Thomas (jonoomph) wrote :

I have fixed the regression with the "Choose a Video or Audio File to Begin" text no longer being translated. Also fixed the "Would you like to import %s as an image sequence?" message. The history messages not being fully translated is a slightly bigger issue, that I don't feel comfortable changing this late in the release cycle. Let's address this after we release 1.3.0. I say we create a new bug report for the history messages.

Changed in openshot:
status: Confirmed → Fix Committed
Revision history for this message
IRIE Shinsuke (irie) wrote :

@Jonathan
I think you also have to apply 'fix_gettext_additional.patch' I attached. Please check it.

Revision history for this message
Jonathan Thomas (jonoomph) wrote :

Yep, you are correct. I missed one of the patches. It is now applied. Thanks!

moimael (moimael)
Changed in openshot:
status: Fix Committed → Fix Released
Revision history for this message
kakurasan (kakurasan) wrote :

This patch fixes some untranslatable strings and untranslated strings in history/"Create new Title" dialog.

Remaining untranslated strings are:
 * "centre", "left", "right", "top", "bottom" in Clip Properties (does not appear in .pot file)
 * "RIGHT", "CENTER", "LEFT", "Simple Star", "Fog Glow", "Streaks", "West", "East", "North", "South" in Animated Title Editor
 * "The Title" in "Create new Title" dialog (from SVG file)
 * "Bar 1", "Bar 2", etc.(from SVG filename) in Title Editor

Revision history for this message
kakurasan (kakurasan) wrote :

Additional fix for "The following codec(s) are missing from your system:" message.

Changed in openshot:
milestone: 1.3.0 → 1.3.1
Revision history for this message
kakurasan (kakurasan) wrote :

I updated the "openshot-1.3.0-gettext.patch" (there was a problem in "Clip Properties" dialog).

Revision history for this message
kakurasan (kakurasan) wrote :

I updated the patch again.
 * Fix regression in openshot-render (cli_render.py)
 * Add more translation fixes
 * Merge missingcodecs.patch

tags: added: patch
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.