gEDA netlisting for NGspice Code Models

This patch looks odd to me... there seem to be conflict markers in the diff. Could you please double-check that it is correct? (I'll try applying it later and make sure it's not just me).

Yep,

I was just cleaning up some things I missed in my last patch set. I
figured if you accepted the code you would rather it be neet and tidy. :-)

  Clif

On Fri, 14 Jan 2011, Peter Clifton wrote:

> When you re-spin the patch file, please be aware that we don't like
> applying patches which mix functionality changes and unconnected
> formatting / comment changes. (Which I noticed in your patch). Those may
> have come from the merge conflict though, so I'll hold judgement until I
> see the new patch.
>
> --
> You received this bug notification because you are a direct subscriber
> of the bug.
> https://bugs.launchpad.net/bugs/702752
>
> Title:
> gEDA netlisting for NGspice Code Models
>
> Status in GPL Electronic Design Automation tools:
> Incomplete
>
> Bug description:
> I came up with a little patch against the current gEDA cvs that allows
> for a custom format string in the spice-sdb backend for the gEDA
> gnetlist util. This allows you to seamlessly use code models in your
> spice simulations. Code models can be useful if you want to quickly
> cobble together a test environment for your circuit. I put together
> some examples on my wiki:
>
> https://www.eugeneweb.com/twiki/bin/view/Sites/CodeModels
>
> Not sure if net-format is the best attribute name for this, but I'm
> sure we could find one for it. :-)
>
> Clif
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/geda/+bug/702752/+subscribe
>

Ok I guess my local repo got hosed somehow. I just submitted a new one.

  Clif

On Fri, 14 Jan 2011, Peter TB Brett wrote:

> Nope, patch definitely does not apply.
>
> --
> You received this bug notification because you are a direct subscriber
> of the bug.
> https://bugs.launchpad.net/bugs/702752
>
> Title:
> gEDA netlisting for NGspice Code Models
>
> Status in GPL Electronic Design Automation tools:
> Incomplete
>
> Bug description:
> I came up with a little patch against the current gEDA cvs that allows
> for a custom format string in the spice-sdb backend for the gEDA
> gnetlist util. This allows you to seamlessly use code models in your
> spice simulations. Code models can be useful if you want to quickly
> cobble together a test environment for your circuit. I put together
> some examples on my wiki:
>
> https://www.eugeneweb.com/twiki/bin/view/Sites/CodeModels
>
> Not sure if net-format is the best attribute name for this, but I'm
> sure we could find one for it. :-)
>
> Clif
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/geda/+bug/702752/+subscribe
>

Nope, patch definitely does not apply.

When you re-spin the patch file, please be aware that we don't like applying patches which mix functionality changes and unconnected formatting / comment changes. (Which I noticed in your patch). Those may have come from the merge conflict though, so I'll hold judgement until I see the new patch.

Sorry about that, I guess my local repo is hosed somehow. Try this one.

Hi Peter,

So how does the new patch look? This feature took about 4 or 5 new lines
of code... I guess now you know what my hidden ajenda was. ;-)

  Clif

On Fri, 14 Jan 2011, Peter TB Brett wrote:

> Nope, patch definitely does not apply.
>
> --
> You received this bug notification because you are a direct subscriber
> of the bug.
> https://bugs.launchpad.net/bugs/702752
>
> Title:
> gEDA netlisting for NGspice Code Models
>
> Status in GPL Electronic Design Automation tools:
> Incomplete
>
> Bug description:
> I came up with a little patch against the current gEDA cvs that allows
> for a custom format string in the spice-sdb backend for the gEDA
> gnetlist util. This allows you to seamlessly use code models in your
> spice simulations. Code models can be useful if you want to quickly
> cobble together a test environment for your circuit. I put together
> some examples on my wiki:
>
> https://www.eugeneweb.com/twiki/bin/view/Sites/CodeModels
>
> Not sure if net-format is the best attribute name for this, but I'm
> sure we could find one for it. :-)
>
> Clif
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/geda/+bug/702752/+subscribe
>

It seems the patch contains at least 3 unrelated changes:
1) add handling of the "net-format" attribute
2) add handling of A? elements
3) fix unrelated comments/whitespace

Does 2) depend on 1) or the other way around?

The patch should be split into 3 and then can be committed to trunk.

Hi,

The net-format attribute works with the A? elements to allow code models to be used in NGspice. Most of the comments are clarifications to routines I wrote. I added the M? comment for compleatnesses sake.

I've split this into two patches (unrelated comments and the actual change), and I'm going to commit them.

It's not stylistically very good Scheme, I'm afraid. ;-) For example, this:

(if (null? format)
  (set! format (gnetlist:get-package-attribute refdes "net-format"))
  (set! format (car format)))

Would be better written as:

(set! format
      (if (null? format)
        (gnetlist:get-package-attribute refdes "net-format")
        (car format)))

Thanks for the patch.

Bug was fixed by a commit
git master commit b6bc950edee6e2e3baa7906f75ebb29c08dac2c8
http://git.gpleda.org/?p=gaf.git;a=commit;h=b6bc950edee6e2e3baa7906f75ebb29c08dac2c8

commit b6bc950edee6e2e3baa7906f75ebb29c08dac2c8
Author: Clif Cox <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gnetlist: flexable netlisting for NGspice Code Models

    Closes-bug: lp-702752
    Reviewed-by: Peter TB Brett <email address hidden>

A commit was made which affects this bug
git master commit 1295421746393d17405b3c4bf37b96caac5f44d0
http://git.gpleda.org/?p=gaf.git;a=commit;h=1295421746393d17405b3c4bf37b96caac5f44d0

commit 1295421746393d17405b3c4bf37b96caac5f44d0
Author: Clif Cox <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gnetlist: Add some comments to spice-sdb backend.

    Affects-bug: lp-702752

Yes, of course, not sure why I missed that.

Peter TB Brett wrote:
> I've split this into two patches (unrelated comments and the actual
> change), and I'm going to commit them.
>
> It's not stylistically very good Scheme, I'm afraid. ;-) For example,
> this:
>
> (if (null? format)
> (set! format (gnetlist:get-package-attribute refdes "net-format"))
> (set! format (car format)))
>
> Would be better written as:
>
> (set! format
> (if (null? format)
> (gnetlist:get-package-attribute refdes "net-format")
> (car format)))
>
> Thanks for the patch.
>
>