Show the file name of the symbol in the attribute editor

Bug #698867 reported by KaiMartin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA
Fix Released
Wishlist
Peter TB Brett

Bug Description

Please show the file name of the symbol in the title bar of the multi attribute editor.

Peter TB Brett (peter-b)
Changed in geda:
assignee: nobody → Peter TB Brett (peter-b)
Peter TB Brett (peter-b)
Changed in geda:
status: New → In Progress
Revision history for this message
gpleda.org commit robot (gpleda-launchpad-robot) wrote :

Bug was fixed by a commit
git master commit 94b19f316a2f259e970a96338ff614d370b1751f
http://git.geda-project.org/geda-gaf/commit/?id=94b19f316a2f259e970a96338ff614d370b1751f

commit 94b19f316a2f259e970a96338ff614d370b1751f
Author: Peter TB Brett <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gschem: Show symbol basename in multiattrib window title.

    Modify the multi-attribute editor dialog box to use a title of the
    form "Edit Attributes - foo.sym". If no object is selected, or
    multiple objects are selected, the title is set to "Edit Attributes"
    as before.

    Closes-bug: lp-698867

Changed in geda:
status: In Progress → Fix Committed
Peter TB Brett (peter-b)
Changed in geda:
milestone: none → 1.9.0
Peter TB Brett (peter-b)
Changed in geda:
status: Fix Committed → Fix Released
Revision history for this message
Peter Clifton (pcjc2) wrote :

I'm considering reverting this change...

As it stands, the dialog title appears to imply you are editing the attributes of the symbol file, and you are not..

Only the inherited attributes actually belong to the filename displayed in the titlebar, and I feel that is misleading.

(Also - might be my hidden motivation... it conflicts with my work on editing multiple objects' attributes at the same time).

Revision history for this message
KaiMartin (kmk-familieknaak) wrote :

Typically, newbies do not intend to edit librariy objecs in the first place. By the time, they want to edit library symbols themselves, they have very certainly grasped that the attribute editor edits the properties of the local instance only. None of my students ever said or did anything that implied they thougt, they would edit the file in the lib. By contrast, more than one mentioned irritation on what symbol the attribute editor actually refers.
In addition, the string in the top bar provides the only UI way to tell the filename of a symbol in the schematic.

If it really itches you, I'd suggest to remove the ".sym" appendix from the string in the dalog head.

Please consider a different solution to your hidden motivation. Why not remove the string, if the editor refers to more than one object?

---<)kaimartin(>---

Revision history for this message
Peter TB Brett (peter-b) wrote :

I don't really have an axe to grind either way. It would be nice to have some trivially discoverable display of which underlying symbol a component uses, if the title bar change is removed.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.