gnetlist: segfault if text is attached to component

Bug #698606 reported by nobody
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA
Fix Released
High
Unassigned

Bug Description

i discovered a perfectly reproducible bug in gnetlist. when i attach text to an inserted symbol in a schematic it segfaults:
Loading schematic [....sch]
...
- Starting internal netlist creation
Segmentation fault

Revision history for this message
nobody (nobody-users) wrote :
Revision history for this message
stefantauner (stefantauner) wrote :

in contrast to the attached file, this works ok (note the different placements for the last curly brace):
v 20100214 2
C 40000 40000 0 0 0 title-A4.sym
C 43200 44900 1 0 0 resistor-2.sym
{
T 43600 45250 5 10 0 0 0 0 1
device=RESISTOR
T 43400 45200 5 10 1 1 0 0 1
refdes=R?
}
T 43500 44700 9 10 1 0 0 0 1
bla

Revision history for this message
Patrick Bernaud (patrickb) wrote :
Revision history for this message
Patrick Bernaud (patrickb) wrote :

The verification performed on attached attributes when extracting name/value is insufficient : it is expected that any text objects attached to a symbol is an attribute. However as in your case, a text object that does not have a valid attribute string (the <name>=<value> format) can be found.

The patch below should fix that problem.

Revision history for this message
sf-robot (sf-robot-users) wrote :

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

Revision history for this message
Peter TB Brett (peter-b) wrote :

Is there any way of doing this that doesn't involve an if-expression with side-effects?

Revision history for this message
Peter TB Brett (peter-b) wrote :

(I've committed this patch anyway).

Peter TB Brett (peter-b)
Changed in geda:
status: Fix Released → Fix Committed
importance: Undecided → High
milestone: none → 1.6.2
Peter TB Brett (peter-b)
Changed in geda:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.