OpenShot Video Editor

inkscape command line quoting

Bug #692799 reported by Winston Ewert on 2010-12-21

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	OpenShot Video Editor	Fix Released	Medium	Unassigned	OpenShot Video Editor 1.3.1

Bug Description

When I request to modify a title in Inkscape this fails if the title contains the character: '

An error message printing to stdout indicates a quoting error.

Version 1.3.0~Alpha1

OS. Ubuntu 10.04

Tags:

moimael (moimael) on 2010-12-26

Changed in openshot:
status:	New → Confirmed
importance:	Undecided → Low

Revision history for this message

moimael (moimael) wrote on 2011-03-03:

inkscapequoting.patch Edit (963 bytes, text/plain)

Here is the patch. It fixes the problem, remove the deprecated os.system functions and replace them with subprocess.Popen and subprocess.call.

Changed in openshot:
assignee:	nobody → moimael (moimael)
milestone:	none → 1.3.1

Revision history for this message

Jonathan Thomas (jonoomph) wrote on 2011-03-07:

Applied the patch, and made a few other changes. There is also an "Advanced Edit" menu on the main form which I applied the same basic code to. And... the error messages were not being correctly translated, so I fixed that as well. subprocess.Popen() is asynchronous, so I added another call to make OpenShot wait for Inkscape to finish, so we can update the thumbnail and preview window correctly, etc...