Nux

libpng14 and nux

Bug #691733 reported by nmarques
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Nux
Won't Fix
Medium
Jay Taoko
Unity
Won't Fix
Undecided
Unassigned
nux (Ubuntu)
Won't Fix
Undecided
Unassigned

Bug Description

nux seems to shatter with libpng14.

=================================================================

make[2]: Entering directory `/usr/src/packages/BUILD/nux-0.9.12/NuxImage'
  CXX libnux_image_0.9_la-BitmapFormats.lo
  CXX libnux_image_0.9_la-Bmp.lo
  CXX libnux_image_0.9_la-CairoGraphics.lo
  CXX libnux_image_0.9_la-DDS.lo
  CXX libnux_image_0.9_la-ImageSurface.lo
  CXX libnux_image_0.9_la-NAnimatedTexture.lo
  CXX libnux_image_0.9_la-NITX.lo
  CXX libnux_image_0.9_la-NPng.lo
./NPng.cpp: In function 'nux::NBitmapData* nux::read_png_rgba(const TCHAR*)':
./NPng.cpp:257:87: error: cannot convert 'long unsigned int*' to 'png_uint_32*' for argument '3' to 'png_uint_32 png_get_IHDR(png_struct*, png_info*, png_uint_32*, png_uint_32*, int*, int*, int*, int*, int*)'
./NPng.cpp:281:87: error: cannot convert 'long unsigned int*' to 'png_uint_32*' for argument '3' to 'png_uint_32 png_get_IHDR(png_struct*, png_info*, png_uint_32*, png_uint_32*, int*, int*, int*, int*, int*)'
./NPng.cpp: In function 'nux::NBitmapData* nux::read_png_rgb(const TCHAR*)':
./NPng.cpp:467:78: error: cannot convert 'long unsigned int*' to 'png_uint_32*' for argument '3' to 'png_uint_32 png_get_IHDR(png_struct*, png_info*, png_uint_32*, png_uint_32*, int*, int*, int*, int*, int*)'
./NPng.cpp:494:78: error: cannot convert 'long unsigned int*' to 'png_uint_32*' for argument '3' to 'png_uint_32 png_get_IHDR(png_struct*, png_info*, png_uint_32*, png_uint_32*, int*, int*, int*, int*, int*)'
./NPng.cpp: In function 'void nux::png_read_resource_fn(png_struct*, png_byte*, png_size_t)':
./NPng.cpp:733:42: warning: 'png_struct_def::io_ptr' is deprecated (declared at /usr/include/libpng14/png.h:1112)
./NPng.cpp:733:42: warning: 'png_struct_def::io_ptr' is deprecated (declared at /usr/include/libpng14/png.h:1112)
./NPng.cpp:738:14: warning: 'png_struct_def::io_ptr' is deprecated (declared at /usr/include/libpng14/png.h:1112)
./NPng.cpp:738:14: warning: 'png_struct_def::io_ptr' is deprecated (declared at /usr/include/libpng14/png.h:1112)
make[2]: *** [libnux_image_0.9_la-NPng.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/usr/src/packages/BUILD/nux-0.9.12/NuxImage'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/src/packages/BUILD/nux-0.9.12'
make: *** [all] Error 2

Revision history for this message
nmarques (nmo-marques) wrote :

Good people,

I apologize for the swiftness of the previous entry. If by any means it's possible to have a upstream possibility of building with libpng14, would be awesome (it works fine with libpng12 btw).

Peace,
NM

Revision history for this message
Devil505 (devil505) wrote :

Dude, try this patch taken from Archlinux AUR

Revision history for this message
nmarques (nmo-marques) wrote :

I'm packaging Unity for openSUSE as a part of a community project. I'm not following paths that will deviate me from upstream, as they might lead to future maintenance nightmares.

The package builds using the compat packages (there is no real need for a libpng14 yet), nevertheless, this should be a upstream feature. I strongly suggest that the patch is submitted to upstream for the benefit of all, thus eliminating the need of deviance from upstream and providing a more relaxed future for maintainers with different software versions on their repos.

Thanks for the tip, a strong +1 for submitting the patch to upstream.

Revision history for this message
Jay Taoko (jaytaoko) wrote :

Thanks for your feedbacks... In the near future, I think we will remove Nux custom image file format loaders in favor of gdk pixbuf. This should resolve the build issue.

Changed in nux:
importance: Undecided → Medium
assignee: nobody → Jay Taoko (jaytaoko)
Alex Launi (alexlauni)
Changed in nux:
status: New → Won't Fix
Changed in unity:
status: New → Won't Fix
Changed in nux (Ubuntu):
status: New → Won't Fix
Revision history for this message
Jay Taoko (jaytaoko) wrote :

The issue mentioned here is no longer an issue. Nux no longer includes the file NPng.cpp

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.