Change vinyl control to use the scratch2 CO

Bug #687500 reported by Sean M. Pappalardo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Owen Williams
1.10
Fix Released
Low
Owen Williams

Bug Description

Currently, vinyl control doesn't behave like every other means of manipulating the waveform in that it doesn't set & clear the Play status which causes a number of problems, most notably other parts of Mixxx being unable to detect if a virtual deck is playing. This could be solved by adjusting it to use the scratch2 CO which allows direct manipulation of the track speed regardless of Play status, allowing the VC code to set & clear the Play status as appropriate. The only trick then is for the VC code to figure out when to set & clear Play. One way is to sample the timecode speed over some amount of real time and if it's playing steadily (within some margin of error,) it should set the Play status. Otherwise, it should clear it. You might use the running average algorithm as implemented in the common MIDI script file for BPM tapping.

Revision history for this message
Owen Williams (ywwg) wrote :

this is fixed in features_xwax2

Changed in mixxx:
assignee: nobody → Owen Williams (ywwg)
status: Confirmed → In Progress
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5707

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.