Launchpad itself

X-Generator: Launchpad (build Unknown)

Bug #682186 reported by Fabien Tassin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Данило Шеган
Launchpad itself 11.01

Bug Description

Please fix the X-Generator header in 'po' files exported by rosetta.

It currently shows "X-Generator: Launchpad (build Unknown)"

It's no big deal in general but it helps see when rosetta bug fixes are supposed to land, like for bug 669831

Related branches

lp://staging/~danilo/launchpad/bug-682186
Henning Eggers (community): Approve (code)
Aaron Bentley (community): Needs Fixing
Diff: 62 lines (+28/-8)
2 files modified
lib/canonical/launchpad/tests/test_versioninfo.py (+24/-0)
lib/canonical/launchpad/versioninfo.py (+4/-8)
Revision history for this message
Данило Шеган (danilo) wrote :

FWIW, we only mark a bug as 'fix released' when it finally hits production servers (so, anything happening after that should use the fixed code). That doesn't change the fact that this is a bug that should be fixed :)

Changed in rosetta:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Данило Шеган (danilo) wrote :

We extract the revno from canonical.launchpad.versioninfo revno, and it's weird that it returns None (which is when we output "Unknown"). That uses bzr-version-info.py to extract the revno.

I've checked with Chex (on of our LOSAs) and he confirms that bzr-version-info.py is present on both crowberry-codehost and loganberry, yet this happens for poexport and translations-export-to-branch.

Revision history for this message
Данило Шеган (danilo) wrote :

I also looked at the contents of bzr-version-info.py on our production servers, it turns out they are fine.

However, reading the code inside lib/canonical/launchpad/versioninfo.py I figured that it might be because we are running scripts out of path. So, the solve this we either need to cd to the LP tree root before running any of our scripts which need version info, or we need to improve versioninfo to read bzr-version-info.py from the LP root, and not from the current directory.

Revision history for this message
Данило Шеган (danilo) wrote :

This affects all emails sent by scripts as well.

affects: rosetta → launchpad-foundations
Changed in launchpad-foundations:
assignee: nobody → Данило Шеган (danilo)
status: Triaged → In Progress
Данило Шеган (danilo)
Changed in launchpad-foundations:
milestone: none → 10.12
Данило Шеган (danilo)
tags: added: bugjam2010
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r12066 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12066>.

Changed in launchpad-foundations:
milestone: 10.12 → none
tags: added: qa-needstesting
Changed in launchpad-foundations:
status: In Progress → Fix Committed
Данило Шеган (danilo)
tags: added: qa-ok
removed: qa-needstesting
Данило Шеган (danilo)
Changed in launchpad:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in launchpad:
milestone: none → 11.01
Revision history for this message
Fabien Tassin (fta) wrote :

it doesn't seem to be fixed

lp:~chromium-team/chromium-browser/chromium-translations-exports.head/generated_resources/zh_CN.po

"X-Launchpad-Export-Date: 2011-01-11 05:58+0000\n"
"X-Generator: Launchpad (build Unknown)\n"

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.